> On Фев. 5, 2015, 9:28 п.п., Jayush Luniya wrote: > > ambari-server/src/main/resources/stacks/HDPWIN/2.2/services/YARN/configuration-mapred/mapred-site.xml, > > line 28 > > <https://reviews.apache.org/r/30676/diff/1/?file=850705#file850705line28> > > > > Since the property is marked the property as deleted. we should not > > have <value></value> under the property as it essentially has no meaning > > and confusing to read a value that isnt correct for Windows. Also lets > > remove the <description></description> > > > > Same goes for all other deleted properties > > > > i.e. > > > > <property> > > <name>mapreduce.admin.user.env</name> > > <deleted>true</deleted> > > </property>
Good point! - Artem ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30676/#review71317 ----------------------------------------------------------- On Фев. 5, 2015, 5:24 п.п., Artem Baranchuk wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30676/ > ----------------------------------------------------------- > > (Updated Фев. 5, 2015, 5:24 п.п.) > > > Review request for Ambari, Eugene Chekanskiy, Florian Barca, and Jayush > Luniya. > > > Bugs: AMBARI-9496 > https://issues.apache.org/jira/browse/AMBARI-9496 > > > Repository: ambari > > > Description > ------- > > Falcon and Pig service checks fails on Windows with Hadoop 2.2 > > > Diffs > ----- > > > ambari-server/src/main/resources/stacks/HDPWIN/2.1/hooks/after-INSTALL/templates/Run-SmokeTests.ps1 > a5c3631 > > ambari-server/src/main/resources/stacks/HDPWIN/2.2/services/FALCON/configuration/falcon-startup.properties.xml > 7651c07 > > ambari-server/src/main/resources/stacks/HDPWIN/2.2/services/YARN/configuration-mapred/mapred-site.xml > d2b7ee1 > > Diff: https://reviews.apache.org/r/30676/diff/ > > > Testing > ------- > > unix test passed > Win hadoop 2.2 cluster deployed success > > > Thanks, > > Artem Baranchuk > >
