-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30796/
-----------------------------------------------------------

Review request for Ambari, Dmitro Lisnichenko and Sid Wagle.


Bugs: AMBARI-9534
    https://issues.apache.org/jira/browse/AMBARI-9534


Repository: ambari


Description
-------

Rename service from /stacks/HDP/2.2/services/AMS to 
/stacks/HDP/2.2/services/AMBARI_METRICS
AMS/metainfo.xml
name = Ambari Metrics
displayname = Ambari Metrics
Rename alerts:
Drop AMS from the alert names. E.g.:
AMS Metric Collector Process => Metrics Collector Process
Metrics Monitor Process
in general refer to "Metrics Monitor" and "Metrics Collector"
Rename Components:
Metrics Collector
Metrics Monitor
Update Service Description
A system for metrics collection that provides storage and retrieval capability 
for metrics collected from the cluster


Diffs
-----

  ambari-metrics/ambari-metrics-timelineservice/conf/unix/ams-site.xml c2dd100 
  ambari-metrics/ambari-metrics-timelineservice/conf/windows/ams-site.xml 
c2dd100 
  
ambari-metrics/ambari-metrics-timelineservice/src/main/resources/scripts/ams_query.py
 d51357a 
  
ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/TestApplicationHistoryClientService.java
 6b06918 
  ambari-server/src/main/java/org/apache/ambari/server/Role.java 228b25b 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractProviderModule.java
 06eaab3 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/timeline/AMSPropertyProvider.java
 666af32 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/timeline/AMSReportPropertyProvider.java
 9752398 
  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FinalizeUpgradeAction.java
 8e32b92 
  ambari-server/src/main/java/org/apache/ambari/server/state/ComponentInfo.java 
10c105a 
  ambari-server/src/main/java/org/apache/ambari/server/state/Service.java 
be5c6d8 
  
ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java
 a8e782e 
  
ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostSummary.java
 1676b35 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/alerts.json
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-env.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-hbase-env.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-hbase-log4j.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-hbase-policy.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-hbase-site.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-log4j.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-site.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/metainfo.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/alerts/alert_ambari_metrics_monitor.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/hbaseSmokeVerify.sh
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/__init__.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/ams.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/ams_service.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/functions.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/hbase.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/hbase_master.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/hbase_regionserver.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/hbase_service.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/metrics_collector.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/metrics_monitor.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/params.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/params_linux.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/params_windows.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/service_check.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/service_mapping.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/status.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/status_params.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/templates/hadoop-metrics2-hbase.properties.j2
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/templates/hbase_client_jaas.conf.j2
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/templates/hbase_grant_permissions.j2
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/templates/hbase_master_jaas.conf.j2
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/templates/hbase_regionserver_jaas.conf.j2
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/templates/metric_groups.conf.j2
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/templates/metric_monitor.ini.j2
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/templates/regionservers.j2
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/templates/smoketest_metrics.json.j2
 PRE-CREATION 
  ambari-server/src/main/resources/common-services/AMS/0.1.0/alerts.json 
ad22f59 
  
ambari-server/src/main/resources/common-services/AMS/0.1.0/configuration/ams-env.xml
 4bb82e7 
  
ambari-server/src/main/resources/common-services/AMS/0.1.0/configuration/ams-hbase-env.xml
 4b23d2f 
  
ambari-server/src/main/resources/common-services/AMS/0.1.0/configuration/ams-hbase-log4j.xml
 47ea220 
  
ambari-server/src/main/resources/common-services/AMS/0.1.0/configuration/ams-hbase-policy.xml
 febbd44 
  
ambari-server/src/main/resources/common-services/AMS/0.1.0/configuration/ams-hbase-site.xml
 b8c96ca 
  
ambari-server/src/main/resources/common-services/AMS/0.1.0/configuration/ams-log4j.xml
 72ca967 
  
ambari-server/src/main/resources/common-services/AMS/0.1.0/configuration/ams-site.xml
 59e5cbb 
  ambari-server/src/main/resources/common-services/AMS/0.1.0/kerberos.json 
7b92469 
  ambari-server/src/main/resources/common-services/AMS/0.1.0/metainfo.xml 
27b3376 
  
ambari-server/src/main/resources/common-services/AMS/0.1.0/package/alerts/alert_ambari_metrics_monitor.py
 a9eb6fa 
  
ambari-server/src/main/resources/common-services/AMS/0.1.0/package/files/hbaseSmokeVerify.sh
 5c320c0 
  
ambari-server/src/main/resources/common-services/AMS/0.1.0/package/scripts/__init__.py
 5561e10 
  
ambari-server/src/main/resources/common-services/AMS/0.1.0/package/scripts/ams.py
 7d46753 
  
ambari-server/src/main/resources/common-services/AMS/0.1.0/package/scripts/ams_service.py
 9260683 
  
ambari-server/src/main/resources/common-services/AMS/0.1.0/package/scripts/functions.py
 a5107d6 
  
ambari-server/src/main/resources/common-services/AMS/0.1.0/package/scripts/hbase.py
 b3bca89 
  
ambari-server/src/main/resources/common-services/AMS/0.1.0/package/scripts/hbase_master.py
 a26254d 
  
ambari-server/src/main/resources/common-services/AMS/0.1.0/package/scripts/hbase_regionserver.py
 8d66dcc 
  
ambari-server/src/main/resources/common-services/AMS/0.1.0/package/scripts/hbase_service.py
 180755f 
  
ambari-server/src/main/resources/common-services/AMS/0.1.0/package/scripts/metric_collector.py
 2a2e181 
  
ambari-server/src/main/resources/common-services/AMS/0.1.0/package/scripts/metric_monitor.py
 f6cce8f 
  
ambari-server/src/main/resources/common-services/AMS/0.1.0/package/scripts/params.py
 eb064f5 
  
ambari-server/src/main/resources/common-services/AMS/0.1.0/package/scripts/params_linux.py
 44d90b7 
  
ambari-server/src/main/resources/common-services/AMS/0.1.0/package/scripts/params_windows.py
 1b3509e 
  
ambari-server/src/main/resources/common-services/AMS/0.1.0/package/scripts/service_check.py
 46eba89 
  
ambari-server/src/main/resources/common-services/AMS/0.1.0/package/scripts/service_mapping.py
 6a96c28 
  
ambari-server/src/main/resources/common-services/AMS/0.1.0/package/scripts/status.py
 91f13d4 
  
ambari-server/src/main/resources/common-services/AMS/0.1.0/package/scripts/status_params.py
 947c992 
  
ambari-server/src/main/resources/common-services/AMS/0.1.0/package/templates/hadoop-metrics2-hbase.properties.j2
 4472abc 
  
ambari-server/src/main/resources/common-services/AMS/0.1.0/package/templates/hbase_client_jaas.conf.j2
 38f9721 
  
ambari-server/src/main/resources/common-services/AMS/0.1.0/package/templates/hbase_grant_permissions.j2
 3378983 
  
ambari-server/src/main/resources/common-services/AMS/0.1.0/package/templates/hbase_master_jaas.conf.j2
 a93c36c 
  
ambari-server/src/main/resources/common-services/AMS/0.1.0/package/templates/hbase_regionserver_jaas.conf.j2
 7097481 
  
ambari-server/src/main/resources/common-services/AMS/0.1.0/package/templates/metric_groups.conf.j2
 aa03d19 
  
ambari-server/src/main/resources/common-services/AMS/0.1.0/package/templates/metric_monitor.ini.j2
 2ee21d4 
  
ambari-server/src/main/resources/common-services/AMS/0.1.0/package/templates/regionservers.j2
 fc6cc37 
  
ambari-server/src/main/resources/common-services/AMS/0.1.0/package/templates/smoketest_metrics.json.j2
 e2e8501 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/role_command_order.json 
0607d9d 
  
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/AMBARI_METRICS/metainfo.xml
 PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/AMS/metainfo.xml 
f0fa469 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py 
2cdecba 
  ambari-server/src/main/resources/stacks/HDP/2.2/services/stack_advisor.py 
6a5aab5 
  
ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/AMBARI_METRICS/configuration/ams-env.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/AMBARI_METRICS/configuration/ams-hbase-env.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/AMBARI_METRICS/configuration/ams-hbase-site.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/AMBARI_METRICS/configuration/ams-log4j.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/AMBARI_METRICS/configuration/ams-site.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/AMBARI_METRICS/metainfo.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/AMS/configuration/ams-env.xml
 3b421b9 
  
ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/AMS/configuration/ams-hbase-env.xml
 ae2aa9a 
  
ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/AMS/configuration/ams-hbase-site.xml
 414f73d 
  
ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/AMS/configuration/ams-log4j.xml
 fcfdc24 
  
ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/AMS/configuration/ams-site.xml
 097de9d 
  ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/AMS/metainfo.xml 
f0fa469 
  
ambari-server/src/main/resources/stacks/HDPWIN/2.2/services/AMBARI_METRICS/metainfo.xml
 PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDPWIN/2.2/services/AMS/metainfo.xml 
c57f6be 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/MetricsServiceProviderTest.java
 9e4131f 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/metrics/timeline/AMSPropertyProviderTest.java
 321e209 
  ambari-server/src/test/python/stacks/2.2/common/test_stack_advisor.py ba6cd8c 
  ambari-web/app/controllers/wizard/step4_controller.js bc433ce 
  ambari-web/app/data/HDP2/site_properties.js 5eb7f22 
  ambari-web/app/models/stack_service.js ad1236f 
  ambari-web/test/controllers/wizard/step4_test.js 3e85a04 
  ambari-web/test/controllers/wizard/step7_test.js 6526010 
  ambari-web/test/mock_data_setup/configs_mock_data.js bfbd2b8 
  ambari-web/test/utils/config_test.js 44e8951 
  
contrib/views/slider/src/main/java/org/apache/ambari/view/slider/SliderAppsViewControllerImpl.java
 9a031e6 
  contrib/views/slider/src/main/resources/ui/app/initialize.js a0dd9a0 

Diff: https://reviews.apache.org/r/30796/diff/


Testing
-------

all tests passed


Thanks,

Dmytro Sen

Reply via email to