> On Feb. 10, 2015, 2:47 p.m., Jonathan Hurley wrote:
> > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/namenode_upgrade.py,
> >  lines 29-31
> > <https://reviews.apache.org/r/30813/diff/1/?file=859743#file859743line29>
> >
> >     If you're making it a class anyway, why not just do this as the higher 
> > Script level and pass in the direction to all of the functions that deal 
> > with rolling upgrades?

I can move it into a constants.py file


- Alejandro


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30813/#review71789
-----------------------------------------------------------


On Feb. 10, 2015, 3:21 a.m., Alejandro Fernandez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30813/
> -----------------------------------------------------------
> 
> (Updated Feb. 10, 2015, 3:21 a.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko, Jonathan Hurley, Nate Cole, 
> Tom Beerbower, and Yurii Shylov.
> 
> 
> Bugs: AMBARI-9541
>     https://issues.apache.org/jira/browse/AMBARI-9541
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Rolling Upgrade down grade is the same as the upgrade, with the exception 
> that the "hdfs dfsadmin -rollingUpgrade prepare" command does not need to be 
> ran.
> 
> 
> Diffs
> -----
> 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/namenode_upgrade.py
>  f74d874 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params.py
>  69cd157 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/utils.py
>  154e6e3 
> 
> Diff: https://reviews.apache.org/r/30813/diff/
> 
> 
> Testing
> -------
> 
> Deployed a 3-node cluster with NamenodeHA, and only HDFS and ZK, then caused 
> a failure on Datanode, performed a downgrade, and it correctly got to 
> Finalize.
> 
> Unit tests are in progress.
> 
> 
> Thanks,
> 
> Alejandro Fernandez
> 
>

Reply via email to