----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30838/#review71892 -----------------------------------------------------------
Ship it! Looks good, just a couple of minor comments. ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FinalizeUpgradeAction.java <https://reviews.apache.org/r/30838/#comment117809> safer to make case insensitive comparison, or use an enum. ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FinalizeUpgradeAction.java <https://reviews.apache.org/r/30838/#comment117810> Cool ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FinalizeUpgradeAction.java <https://reviews.apache.org/r/30838/#comment117812> Printing all of the hosts can be a really long list! ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FinalizeUpgradeAction.java <https://reviews.apache.org/r/30838/#comment117813> To answer your question; No. I believe this will only happen when the heartbeat reports a change in the version. - Alejandro Fernandez On Feb. 10, 2015, 5:50 p.m., Nate Cole wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30838/ > ----------------------------------------------------------- > > (Updated Feb. 10, 2015, 5:50 p.m.) > > > Review request for Ambari, Alejandro Fernandez and Yurii Shylov. > > > Bugs: AMBARI-9540 > https://issues.apache.org/jira/browse/AMBARI-9540 > > > Repository: ambari > > > Description > ------- > > Update for FinalizeUpgradeAction to handle a downgrade and getting back to a > state where the upgrade can be retried. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FinalizeUpgradeAction.java > 8e32b92 > > ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/UpgradeActionTest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/30838/diff/ > > > Testing > ------- > > Manual UI testing up to final finalize, then click downgrade. All green with > the option to click Upgrade again. > > Tests run: 2657, Failures: 0, Errors: 0, Skipped: 15 > > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 22:13.852s > [INFO] Finished at: Tue Feb 10 12:43:36 EST 2015 > [INFO] Final Memory: 34M/372M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Nate Cole > >
