----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30854/#review71959 -----------------------------------------------------------
Ship it! Ship It! - Dmitro Lisnichenko On Feb. 11, 2015, 12:19 a.m., Alejandro Fernandez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30854/ > ----------------------------------------------------------- > > (Updated Feb. 11, 2015, 12:19 a.m.) > > > Review request for Ambari, Dmitro Lisnichenko, Jonathan Hurley, Nate Cole, > Robert Levas, Tom Beerbower, and Yurii Shylov. > > > Bugs: AMBARI-9559 > https://issues.apache.org/jira/browse/AMBARI-9559 > > > Repository: ambari > > > Description > ------- > > While performing a RU, it failed in Finalize because the SECONDARY_NAMENODE > component was still on an old version, since it was not deleted by the > Namenode HA wizard. > This was a 3-node cluster with HDFS, MR, YARN, TEZ, Hive, ZK, Pig, AMS using > HDP 2.2.0.0 GA. > > I was not able to reproduce this, even after installing the exact same > services on the same hosts, and using the same ambari-server version. It > could be the case that some thread is holding a reference to the object that > is being deleted, so it persists. So I added another check to > PreUpgradeCheckResourceProvider that ensures that SECONDARY_NAMENODE is not > present on any hosts. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/checks/SecondaryNamenodeDeletedCheck.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/PreUpgradeCheckResourceProvider.java > 38cb8c2 > > ambari-server/src/main/java/org/apache/ambari/server/stack/MasterHostResolver.java > ed98aaf > > Diff: https://reviews.apache.org/r/30854/diff/ > > > Testing > ------- > > Deployed a 3-node cluster with HDFS, ZK, and added Namenode HA. Then > registered a repo and distributed it to the hosts. Next, I stopped > ambari-server and manually edited the database to simulate SECONDARY_NAMENODE > still being present. > > INSERT INTO hostcomponentdesiredstate VALUES (2, 'SECONDARY_NAMENODE', > E'{\"stackName\":\"HDP\",\"stackVersion\":\"2.2\"}', 'INSTALLED', > 'c6402.ambari.apache.org', 'HDFS', '', 'OFF', 'UNSECURED', 0); > INSERT INTO hostcomponentstate VALUES (2, 'SECONDARY_NAMENODE', > '2.2.0.0-2041', E'{\"stackName\":\"HDP\",\"stackVersion\":\"2.2\"}', > 'INSTALLED', 'c6402.ambari.apache.org', 'HDFS', 'NONE', 'UNSECURED'); > > I then queried, > http://c6401.ambari.apache.org:8080/api/v1/clusters/c1/rolling_upgrades_check?fields=*&UpgradeChecks/repository_version=2.2.1.0-2260&_=1423612069190 > and got the following, as expected, > > ``` > { > href: > "http://c6401.ambari.apache.org:8080/api/v1/clusters/c1/rolling_upgrades_check/SECONDARY_NAMENODE_MUST_BE_DELETED";, > UpgradeChecks: { > check: "The SECONDARY_NAMENODE component must be deleted from all hosts", > check_type: "SERVICE", > cluster_name: "c1", > failed_on: [ > "SECONDARY_NAMENODE" > ], > id: "SECONDARY_NAMENODE_MUST_BE_DELETED", > reason: "The SECONDARY_NAMENODE component must be deleted from host(s): > c6402.ambari.apache.org. Please use the REST API to delete it.", > repository_version: "2.2.1.0-2260", > status: "FAIL" > } > } > ``` > > Unit tests are in progress. > > > Thanks, > > Alejandro Fernandez > >
