----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30899/#review72090 -----------------------------------------------------------
Ship it! The changes seems fine in that it looks like it will fix the issue that was raised. However, there seem to be other problems with the existing code that can/should be looked at in a follow-up jira. - Hitesh Shah On Feb. 11, 2015, 10:42 p.m., Alejandro Fernandez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30899/ > ----------------------------------------------------------- > > (Updated Feb. 11, 2015, 10:42 p.m.) > > > Review request for Ambari, Jonathan Hurley, Nate Cole, Sumit Mohanty, > Srimanth Gunturi, and Tom Beerbower. > > > Bugs: AMBARI-9585 > https://issues.apache.org/jira/browse/AMBARI-9585 > > > Repository: ambari > > > Description > ------- > > Today, the tez tarball is copied to HDFS only when HiveServer2 is installed, > and when the Pig Service check runs. > Instead, this should happen whenever Tez is installed. > For a RU, the install of new bits should also copy the tarball to HDFS. > > > Diffs > ----- > > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server.py > abfde14 > > ambari-server/src/main/resources/common-services/PIG/0.12.0.2.0/package/scripts/service_check.py > 7137e60 > > ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/tez_client.py > 00375d7 > ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_server.py 1fc3fbf > ambari-server/src/test/python/stacks/2.1/TEZ/test_tez_client.py 3d74113 > > Diff: https://reviews.apache.org/r/30899/diff/ > > > Testing > ------- > > Installed a 3-node cluster with HDFS, ZK, MR, YARN, and Tez. > Then ensured that the tez tarball was copied to hdfs, > > su - hdfs -c 'hdfs dfs -ls /hdp/apps/2.2.0.0-2041/tez' > > When I installed Pig client, on the same host that had the tez client, I was > able to run a Pig job, using the following example, > http://hortonworks.com/hadoop-tutorial/faster-pig-tez/ > > I then performed a Rolling Upgrade and the newer tez tarball was indeed > copied to HDFS. > su - hdfs -c 'hdfs dfs -ls /hdp/apps/2.2.1.0-2260/tez' > > Unit tests are in progress. > > > Thanks, > > Alejandro Fernandez > >
