-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30932/
-----------------------------------------------------------

Review request for Ambari, Nate Cole and Tom Beerbower.


Bugs: AMBARI-9597
    https://issues.apache.org/jira/browse/AMBARI-9597


Repository: ambari


Description
-------

When changing the name of an Alert Definition, the current alerts associated 
with that definition don't reflect the name change. We want current alerts and 
alerts movingn forward to reflect the name change, but not the past alerts.


Diffs
-----

  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertDefinitionResourceProvider.java
 d57bbd0 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertResourceProvider.java
 10b93aa 
  
ambari-server/src/main/java/org/apache/ambari/server/events/AlertDefinitionChangedEvent.java
 ad063a3 
  
ambari-server/src/main/java/org/apache/ambari/server/events/listeners/alerts/AlertLifecycleListener.java
 f21d800 
  
ambari-server/src/main/java/org/apache/ambari/server/events/listeners/alerts/AlertReceivedListener.java
 a5a3614 
  ambari-server/src/main/java/org/apache/ambari/server/orm/dao/AlertsDAO.java 
34216e7 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/AlertCurrentEntity.java
 6fe825f 
  
ambari-server/src/main/java/org/apache/ambari/server/state/alert/AlertDefinition.java
 897109c 
  
ambari-server/src/main/java/org/apache/ambari/server/state/alert/AlertDefinitionFactory.java
 02c80ed 
  
ambari-server/src/test/java/org/apache/ambari/server/orm/dao/AlertsDAOTest.java 
d588069 
  
ambari-server/src/test/java/org/apache/ambari/server/state/alerts/AlertEventPublisherTest.java
 6331516 

Diff: https://reviews.apache.org/r/30932/diff/


Testing
-------

Manual verification of the issue and the fix, including that history does not 
change. Added new tests.


Thanks,

Jonathan Hurley

Reply via email to