----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30968/#review72371 -----------------------------------------------------------
Ship it! Ship It! - Tom Beerbower On Feb. 13, 2015, 6:35 a.m., Jonathan Hurley wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30968/ > ----------------------------------------------------------- > > (Updated Feb. 13, 2015, 6:35 a.m.) > > > Review request for Ambari, Nate Cole and Tom Beerbower. > > > Bugs: AMBARI-9615 > https://issues.apache.org/jira/browse/AMBARI-9615 > > > Repository: ambari > > > Description > ------- > > When an execution command is sent to an agent, it only checks to see if any > of the existing alerts have configuration data changes. If none do, the > updated configurations are not written to definitions.json. > > On an execution command, definitions.json should always have its > configuration section updated. > > Basically always ensure that definitions.json includes the latest > configurations from the execution command. > > > Diffs > ----- > > ambari-agent/src/main/python/ambari_agent/AlertSchedulerHandler.py 87295d2 > ambari-agent/src/main/python/ambari_agent/Controller.py d597bca > ambari-agent/src/main/python/ambari_agent/alerts/base_alert.py 283da9c > ambari-agent/src/main/python/ambari_agent/alerts/metric_alert.py ebd205d > ambari-agent/src/main/python/ambari_agent/alerts/port_alert.py 1ae625c > ambari-agent/src/main/python/ambari_agent/alerts/script_alert.py 35cd42e > ambari-agent/src/main/python/ambari_agent/alerts/web_alert.py f736135 > ambari-agent/src/test/python/ambari_agent/TestAlerts.py 4cbab14 > > ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/alerts.json > 86276bd > > Diff: https://reviews.apache.org/r/30968/diff/ > > > Testing > ------- > > ---------------------------------------------------------------------- > Ran 286 tests in 8.161s > > OK > [INFO] > [INFO] --- apache-rat-plugin:0.11:check (default) @ ambari-agent --- > [INFO] 51 implicit excludes (use -debug for more details). > [INFO] Exclude: src/examples/* > [INFO] Exclude: src/test/python/dummy*.txt > [INFO] Exclude: src/test/python/ambari_agent/dummy_files/* > [INFO] Exclude: src/test/python/ambari_agent/dummy*.txt > [INFO] Exclude: src/main/python/ambari_agent/imports.txt > [INFO] Exclude: src/main/python/ambari_agent/apscheduler/** > [INFO] Exclude: etc/sudoers.d/ambari-agent > [INFO] Exclude: **/*.erb > [INFO] Exclude: **/*.json > [INFO] Exclude: **/*.pydevproject > [INFO] Exclude: **/*.wxs > [INFO] 213 resources included (use -debug for more details) > Warning: org.apache.xerces.jaxp.SAXParserImpl$JAXPSAXParser: Property > 'http://www.oracle.com/xml/jaxp/properties/entityExpansionLimit' is not > recognized. > Warning: org.apache.xerces.parsers.SAXParser: Feature > 'http://javax.xml.XMLConstants/feature/secure-processing' is not recognized. > Warning: org.apache.xerces.parsers.SAXParser: Property > 'http://www.oracle.com/xml/jaxp/properties/entityExpansionLimit' is not > recognized. > [INFO] Rat check: Summary of files. Unapproved: 0 unknown: 0 generated: 0 > approved: 121 licence. > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 10.630 s > [INFO] Finished at: 2015-02-13T01:29:01-05:00 > [INFO] Final Memory: 8M/81M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Jonathan Hurley > >
