-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31006/#review72425
-----------------------------------------------------------


Tom, with the new changes I think you might break the builds where set:version 
will replace {{ambari.version}} with correct value. Better to verify with build 
that it wont break.

- Srimanth Gunturi


On Feb. 13, 2015, 7:48 p.m., Tom Beerbower wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31006/
> -----------------------------------------------------------
> 
> (Updated Feb. 13, 2015, 7:48 p.m.)
> 
> 
> Review request for Ambari and Nate Cole.
> 
> 
> Bugs: AMBARI-9631
>     https://issues.apache.org/jira/browse/AMBARI-9631
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Update ambari.version property in all pom.xml files under 
> ambari-views/examples.
> 
> 
> Diffs
> -----
> 
>   ambari-views/examples/calculator-view/pom.xml ce89ebc 
>   ambari-views/examples/favorite-view/pom.xml 2d64dd9 
>   ambari-views/examples/hello-servlet-view/pom.xml f2c2438 
>   ambari-views/examples/helloworld-view/pom.xml d53e9d7 
>   ambari-views/examples/phone-list-view/pom.xml 6662011 
>   ambari-views/examples/pom.xml 4e93c35 
>   ambari-views/examples/property-validator-view/pom.xml 9429a86 
>   ambari-views/examples/property-view/pom.xml 45aebfa 
>   ambari-views/examples/restricted-view/pom.xml 3574f73 
>   ambari-views/examples/simple-view/pom.xml e23faca 
>   ambari-views/examples/weather-view/pom.xml fd6d5b6 
> 
> Diff: https://reviews.apache.org/r/31006/diff/
> 
> 
> Testing
> -------
> 
> No new functionality, so no new tests required.
> 
> All existing tests pass.
> 
> 
> Thanks,
> 
> Tom Beerbower
> 
>

Reply via email to