----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31111/#review72711 -----------------------------------------------------------
Ship it! Ship It! - Dmitro Lisnichenko On Feb. 17, 2015, 1:38 p.m., Dmytro Sen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31111/ > ----------------------------------------------------------- > > (Updated Feb. 17, 2015, 1:38 p.m.) > > > Review request for Ambari, Dmitro Lisnichenko and Myroslav Papirkovskyy. > > > Bugs: AMBARI-9651 > https://issues.apache.org/jira/browse/AMBARI-9651 > > > Repository: ambari > > > Description > ------- > > Details to be flushed out > > Items: > Validation > Do not allow queries with missing METRIC_NAMES. > Verify the time range queries for precision table do not exceed row count > limit, warn the user to query aggregate table > Error handling > Return appropriate HTTP error codes for exceptions thrown by the AMS API. > > > Diffs > ----- > > > ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/HBaseTimelineMetricStore.java > 88086d6 > > ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/PhoenixHBaseAccessor.java > 6ffdc38 > > ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/PhoenixTransactSQL.java > c3f231f > > ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/webapp/TimelineWebServices.java > d6d637f > > ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/service_check.py > b5a5745 > > Diff: https://reviews.apache.org/r/31111/diff/ > > > Testing > ------- > > [INFO] ambari-metrics .................................... SUCCESS [0.837s] > [INFO] ambari-metrics-common ............................. SUCCESS [3.611s] > [INFO] ambari-metrics-hadoop-sink ........................ SUCCESS [3.229s] > [INFO] ambari-metrics-flume-sink ......................... SUCCESS [2.125s] > [INFO] ambari-metrics-kafka-sink ......................... SUCCESS [4.350s] > [INFO] ambari-metrics-storm-sink ......................... SUCCESS [1.415s] > [INFO] ambari-metrics-timelineservice .................... SUCCESS [3:51.492s] > [INFO] ambari-metrics-host-monitoring .................... SUCCESS [2.859s] > [INFO] ambari-metrics-assembly ........................... SUCCESS [4:47.194s] > > > Thanks, > > Dmytro Sen > >
