> On Feb. 18, 2015, 7:26 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariAuthorizationFilter.java, > > lines 97-101 > > <https://reviews.apache.org/r/31159/diff/1/?file=867868#file867868line97> > > > > Just a question; if you're not authenticated but you do have a token, > > wouldn't you want to use the token instead of redirecting to login?
Good catch. Yes, I'll fix it. - Tom ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31159/#review72984 ----------------------------------------------------------- On Feb. 18, 2015, 7:06 p.m., Tom Beerbower wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31159/ > ----------------------------------------------------------- > > (Updated Feb. 18, 2015, 7:06 p.m.) > > > Review request for Ambari, Jonathan Hurley, Nate Cole, and Yusaku Sako. > > > Bugs: AMBARI-9694 > https://issues.apache.org/jira/browse/AMBARI-9694 > > > Repository: ambari > > > Description > ------- > > Access a view (i.e. > "http://c6501.ambari.apache.org:8080/views/TEZ/0.5.2.2.2.2.0-869/tez/#/tez-app/application_1423719241211_0050";) > from a browser where I have already logged in to Ambari, the link works fine. > When I access it from another browser, I get a 403 with no redirect to the > login page. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariAuthorizationFilter.java > bedffbb > > ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AmbariAuthorizationFilterTest.java > f3c6400 > > Diff: https://reviews.apache.org/r/31159/diff/ > > > Testing > ------- > > Manual tested. > New unit test added. > > All existing tests pass ... > > > Thanks, > > Tom Beerbower > >
