> On Feb. 23, 2015, 4:33 p.m., Nate Cole wrote:
> > Can you write a test to cover the change?  Kerberos won't be announcing any 
> > versions, so we should just make a confirmation of that.

Current review is not actual anymore since the patch has been discarded in 
jira. Sorry, forgot to close it


- Dmitro


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31128/#review73580
-----------------------------------------------------------


On Feb. 17, 2015, 7:28 p.m., Dmitro Lisnichenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31128/
> -----------------------------------------------------------
> 
> (Updated Feb. 17, 2015, 7:28 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Nate Cole, and Tom Beerbower.
> 
> 
> Bugs: AMBARI-9681
>     https://issues.apache.org/jira/browse/AMBARI-9681
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Could not reproduce an issue, but patch should theoretically fix it (if 
> stack_name is not defined at params.py, component version would not be 
> reported)
> 
> 
> Diffs
> -----
> 
>   
> ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/package/scripts/params.py
>  3705cfe 
> 
> Diff: https://reviews.apache.org/r/31128/diff/
> 
> 
> Testing
> -------
> 
> Manual verification + unit tests
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>

Reply via email to