> On Feb. 23, 2015, 3:08 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java, > > line 1553 > > <https://reviews.apache.org/r/31314/diff/1/?file=873070#file873070line1553> > > > > There's a class called ServiceComponentHostSummary with the method > > haveAllComponentsFinishedAdvertisingVersion() that can be used instead.
That's not quite enough though, because that method would return true when there is NOTHING advertising version, and that's not what I want to check. - Nate ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31314/#review73651 ----------------------------------------------------------- On Feb. 23, 2015, 2:55 p.m., Nate Cole wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31314/ > ----------------------------------------------------------- > > (Updated Feb. 23, 2015, 2:55 p.m.) > > > Review request for Ambari, Alejandro Fernandez and Dmitro Lisnichenko. > > > Bugs: AMBARI-9755 > https://issues.apache.org/jira/browse/AMBARI-9755 > > > Repository: ambari > > > Description > ------- > > * When marking a cluster version as CURRENT, take into account hosts that > don't advertise version and add a host_version record. > * Fixed error in a ZK import. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java > c609b0a > > ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5.2.0/package/scripts/zookeeper_server.py > 92465a0 > > ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterTest.java > 8865b26 > > ambari-server/src/test/resources/stacks/HDP/2.0.5/services/ZOOKEEPER/metainfo.xml > e17bbd3 > > Diff: https://reviews.apache.org/r/31314/diff/ > > > Testing > ------- > > Manual testing on new and upgrading cluster. Automated testing pending. > > > Thanks, > > Nate Cole > >
