----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31381/#review73941 -----------------------------------------------------------
Ship it! Ship It! - Tom Beerbower On Feb. 24, 2015, 9:27 p.m., Jonathan Hurley wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31381/ > ----------------------------------------------------------- > > (Updated Feb. 24, 2015, 9:27 p.m.) > > > Review request for Ambari, Nate Cole and Tom Beerbower. > > > Bugs: AMBARI-9781 > https://issues.apache.org/jira/browse/AMBARI-9781 > > > Repository: ambari > > > Description > ------- > > Configured NameNode HA. Build #435, 3-node cluster > > The Percent JournalNodes Available alert has no instances. But the > JournalNode process alert has three instances as expected. > > This happens when the alert has not run yet and the component is brought > online. The first time the alert runs, it records an OK, which is technically > not a state change (since there was no prior state). Because no state change > occurred, the aggregate listener did not fire. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/events/InitialAlertEvent.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/events/listeners/alerts/AlertAggregateListener.java > fdc20df > > ambari-server/src/main/java/org/apache/ambari/server/events/listeners/alerts/AlertReceivedListener.java > c65445d > ambari-server/src/test/java/org/apache/ambari/server/events/EventsTest.java > de58971 > > ambari-server/src/test/java/org/apache/ambari/server/events/MockEventListener.java > 4b6fe11 > > ambari-server/src/test/java/org/apache/ambari/server/state/alerts/InitialAlertEventTest.java > PRE-CREATION > > ambari-server/src/test/java/org/apache/ambari/server/state/cluster/AlertDataManagerTest.java > db0f284 > > Diff: https://reviews.apache.org/r/31381/diff/ > > > Testing > ------- > > Removed all historical and current alerts and restarted Ambari server. > Verified that the aggregates are calculated. Unit tests written to cover the > new event class that was written. > > > Thanks, > > Jonathan Hurley > >
