> On Feb. 25, 2015, 1:25 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/java/org/apache/ambari/server/checks/CheckDescription.java, > > line 34 > > <https://reviews.apache.org/r/31391/diff/1/?file=874588#file874588line34> > > > > Can we make the keys in the HashMap enums?
Will put in a future patch. - Nate ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31391/#review73948 ----------------------------------------------------------- On Feb. 24, 2015, 11:31 p.m., Nate Cole wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31391/ > ----------------------------------------------------------- > > (Updated Feb. 24, 2015, 11:31 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and > Jonathan Hurley. > > > Bugs: AMBARI-9780 > https://issues.apache.org/jira/browse/AMBARI-9780 > > > Repository: ambari > > > Description > ------- > > * Centralize description text > * Correct error descriptions > * Enable checking results for other checks as "dependent checks" (for NN HA) > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/checks/AbstractCheckDescriptor.java > c43d843 > > ambari-server/src/main/java/org/apache/ambari/server/checks/CheckDescription.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/checks/HostsHeartbeatCheck.java > 9e76928 > > ambari-server/src/main/java/org/apache/ambari/server/checks/HostsMasterMaintenanceCheck.java > 7bdce47 > > ambari-server/src/main/java/org/apache/ambari/server/checks/HostsRepositoryVersionCheck.java > f9bcdd9 > > ambari-server/src/main/java/org/apache/ambari/server/checks/SecondaryNamenodeDeletedCheck.java > 6ba28f1 > > ambari-server/src/main/java/org/apache/ambari/server/checks/ServicesDecommissionCheck.java > 6ac0326 > > ambari-server/src/main/java/org/apache/ambari/server/checks/ServicesMaintenanceModeCheck.java > 5043d31 > > ambari-server/src/main/java/org/apache/ambari/server/checks/ServicesMapReduceDistributedCacheCheck.java > c388a81 > > ambari-server/src/main/java/org/apache/ambari/server/checks/ServicesNamenodeHighAvailabilityCheck.java > d9f8704 > > ambari-server/src/main/java/org/apache/ambari/server/checks/ServicesTezDistributedCacheCheck.java > 8859370 > > ambari-server/src/main/java/org/apache/ambari/server/checks/ServicesUpCheck.java > e2b7657 > > ambari-server/src/main/java/org/apache/ambari/server/checks/ServicesYarnWorkPreservingCheck.java > 3b06076 > > ambari-server/src/main/java/org/apache/ambari/server/controller/PrereqCheckRequest.java > 5f33914 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/PreUpgradeCheckResourceProvider.java > 2220b2b > ambari-server/src/main/java/org/apache/ambari/server/state/CheckHelper.java > f4b0b52 > > ambari-server/src/main/java/org/apache/ambari/server/state/stack/PrerequisiteCheck.java > 4ed2fb3 > > ambari-server/src/test/java/org/apache/ambari/server/checks/AbstractCheckDescriptorTest.java > 716d033 > > ambari-server/src/test/java/org/apache/ambari/server/checks/HostsHeartbeatCheckTest.java > fa20373 > > ambari-server/src/test/java/org/apache/ambari/server/checks/HostsMasterMaintenanceCheckTest.java > 9444aa3 > > ambari-server/src/test/java/org/apache/ambari/server/checks/HostsRepositoryVersionCheckTest.java > 02fd01e > > ambari-server/src/test/java/org/apache/ambari/server/checks/SecondaryNamenodeDeletedCheckTest.java > 4938468 > > ambari-server/src/test/java/org/apache/ambari/server/checks/ServicesDecommissionCheckTest.java > 71e61e2 > > ambari-server/src/test/java/org/apache/ambari/server/checks/ServicesMaintenanceModeCheckTest.java > c8c8bd8 > > ambari-server/src/test/java/org/apache/ambari/server/checks/ServicesMapReduceDistributedCacheCheckTest.java > a8a09bd > > ambari-server/src/test/java/org/apache/ambari/server/checks/ServicesNamenodeHighAvailabilityCheckTest.java > c1b2022 > > ambari-server/src/test/java/org/apache/ambari/server/checks/ServicesTezDistributedCacheCheckTest.java > c4dcc5e > > ambari-server/src/test/java/org/apache/ambari/server/checks/ServicesUpCheckTest.java > ad60f1c > > ambari-server/src/test/java/org/apache/ambari/server/checks/ServicesYarnWorkPreservingCheckTest.java > 2135c19 > > ambari-server/src/test/java/org/apache/ambari/server/state/CheckHelperTest.java > 72b89ca > > Diff: https://reviews.apache.org/r/31391/diff/ > > > Testing > ------- > > Tests run: 2737, Failures: 0, Errors: 0, Skipped: 15 > > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 20:27.410s > [INFO] Finished at: Tue Feb 24 18:00:21 EST 2015 > [INFO] Final Memory: 32M/375M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Nate Cole > >
