----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31370/#review74275 -----------------------------------------------------------
Ship it! ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java <https://reviews.apache.org/r/31370/#comment120819> minor nit: instead of doing an equalsIgnoreCase twice for "SET_KEYTAB" why not just get the "added" var before the if block and then change the if condition to if (added || "REMOVE_KEYTAB".equalsIgnoreCase(customCommand)) ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelper.java <https://reviews.apache.org/r/31370/#comment120823> Why convert the domain specific checked exception to an IllegalArgumentException here? This makes using this method more difficult. Typically only code that is directly dealing with user requests such as resource providers should do this conversion to ensure the proper response to the user. Code at this level should throw the proper checked exception. If you disagree and decide to still throw the IllegalArgumentException, please add the exception to the javadoc. ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelper.java <https://reviews.apache.org/r/31370/#comment120824> is this english? ;) ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelper.java <https://reviews.apache.org/r/31370/#comment120825> wither -> either - John Speidel On Feb. 25, 2015, 1:27 a.m., Robert Levas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31370/ > ----------------------------------------------------------- > > (Updated Feb. 25, 2015, 1:27 a.m.) > > > Review request for Ambari, Andrew Onischuk, John Speidel, Robert Nettleton, > and Vitalyi Brodetskyi. > > > Bugs: AMBARI-9749 > https://issues.apache.org/jira/browse/AMBARI-9749 > > > Repository: ambari > > > Description > ------- > > After smoke test user is created during the Check Kerberos task at the > beginning of the wizard, delete the principal because later in the wizard the > user might have changed the principal name, making this principal unused. > > To do this a delete keytabs stage is added to the Kerberos service check > workflow that class a new custom command `REMOVE_KEYTAB` on the agent side. > Code is added to the `HeartbeatHandler` to determine whether keytabs are > being _set_ or _removed_ to behave properly. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java > 14e524e > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java > 3db0830 > > ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelper.java > e562497 > > ambari-server/src/main/java/org/apache/ambari/server/orm/dao/KerberosPrincipalHostDAO.java > fef0597 > > ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/metainfo.xml > 32d97b1 > > ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/package/scripts/kerberos_client.py > 717b96d > > ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/package/scripts/kerberos_common.py > d723628 > > ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/package/scripts/service_check.py > 02b2ce2 > > ambari-server/src/main/resources/stacks/HDP/2.2.GlusterFS/services/KERBEROS/metainfo.xml > 8751892 > > ambari-server/src/main/resources/stacks/HDP/2.2.GlusterFS/services/KERBEROS/package/scripts/kerberos_client.py > 06d8eb6 > > ambari-server/src/main/resources/stacks/HDP/2.2.GlusterFS/services/KERBEROS/package/scripts/kerberos_common.py > 269658b > > ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatHandler.java > 95833ea > > ambari-server/src/test/java/org/apache/ambari/server/controller/KerberosHelperTest.java > c80970a > ambari-server/src/test/python/stacks/2.2/KERBEROS/test_kerberos_client.py > 2b69f1a > > Diff: https://reviews.apache.org/r/31370/diff/ > > > Testing > ------- > > Manually tested in clusters using a MIT KDC and an Active Directory > > # Local test results: > > Running org.apache.ambari.server.agent.TestHeartbeatHandler > Tests run: 34, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 77.889 sec > > Running org.apache.ambari.server.controller.KerberosHelperTest > Tests run: 22, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.916 sec > > Ambari server test suite > Tests run: 2744, Failures: 0, Errors: 0, Skipped: 15 > > > # Jenkins test results: having issues unrelated to this patch > ``` > [ERROR] Failed to execute goal on project ambari-server: Could not resolve > dependencies for project org.apache.ambari:ambari-server:jar:2.0.0-SNAPSHOT: > Failed to collect dependencies at > org.apache.ambari:ambari-metrics-common:jar:2.0.0-SNAPSHOT: Failed to read > artifact descriptor for > org.apache.ambari:ambari-metrics-common:jar:2.0.0-SNAPSHOT: Failure to find > org.apache.ambari:ambari-metrics:pom:2.0.0-SNAPSHOT in > https://oss.sonatype.org/content/groups/staging was cached in the local > repository, resolution will not be reattempted until the update interval of > oss.sonatype.org has elapsed or updates are forced -> [Help 1] > ``` > > > Thanks, > > Robert Levas > >
