----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31537/#review74470 -----------------------------------------------------------
Ship it! `ambari-agent/src/test/python/tmp_hostcheck.result` needs to be removed and I think most of the the injector stuff in `org.apache.ambari.server.serveraction.kerberos.MITKerberosOperationHandler` should be moved out to the `org.apache.ambari.server.serveraction.kerberos.KerberosOperationHandlerFactory`. But due to time constraints, after `ambari-agent/src/test/python/tmp_hostcheck.result`, it can be merged. - Robert Levas On Feb. 27, 2015, 5:52 a.m., Vitalyi Brodetskyi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31537/ > ----------------------------------------------------------- > > (Updated Feb. 27, 2015, 5:52 a.m.) > > > Review request for Ambari, Andrew Onischuk, Dmitro Lisnichenko, and Robert > Levas. > > > Bugs: AMBARI-9826 > https://issues.apache.org/jira/browse/AMBARI-9826 > > > Repository: ambari > > > Description > ------- > > STR: > 1)Deploy old version with all services > 2)Make ambari only upgrade to 2.0.0 > 3)Try to enable security (MIT) > Actual result: > Test Kerberos Client failed (Enebling security) after Ambari only upgrade > from 1.7.0 to 2.0.0 > Expected result > Enable Securiry passed. > > > Diffs > ----- > > ambari-agent/src/test/python/tmp_hostcheck.result PRE-CREATION > > ambari-common/src/main/python/resource_management/libraries/functions/__init__.py > 44d235c > > ambari-common/src/main/python/resource_management/libraries/functions/get_kdestroy_path.py > PRE-CREATION > > ambari-common/src/main/python/resource_management/libraries/functions/get_kinit_path.py > 74d331d > > ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/MITKerberosOperationHandler.java > 152d29c > > ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/params.py > a2d5957 > > ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/status_params.py > 0d61941 > > ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/params.py > c1f0b12 > > ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/status_params.py > facc983 > > ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params.py > 7f50440 > > ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/status_params.py > 1487ae0 > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params.py > 2d296ec > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/status_params.py > c3e5832 > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/alerts/alert_hive_thrift_port.py > 9979530 > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/alerts/alert_webhcat_server.py > 970ddde > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params.py > 61043da > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/status_params.py > 14300d5 > > ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/package/scripts/kerberos_common.py > d723628 > > ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/package/scripts/status_params.py > 4fabf6c > > ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params.py > 7155f1a > > ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/status_params.py > 1bf7427 > > ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/alerts/alert_check_oozie_server.py > a5a066b > > ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/params.py > a129a6c > > ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/status_params.py > f66448d > > ambari-server/src/main/resources/common-services/PIG/0.12.0.2.0/package/scripts/params.py > 3d4acac > > ambari-server/src/main/resources/common-services/SLIDER/0.60.0.2.2/package/scripts/params.py > 8ef2ca7 > > ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/params.py > 800bd7c > > ambari-server/src/main/resources/common-services/SQOOP/1.4.4.2.0/package/scripts/params.py > 92e2b82 > > ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/status_params.py > 663eb8e > > ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/params.py > 84c28a4 > > ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params.py > 3f0b151 > > ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/status_params.py > 3cfff05 > > ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5.2.0/package/scripts/params.py > a8652ea > > ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5.2.0/package/scripts/status_params.py > a097483 > > ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/MITKerberosOperationHandlerTest.java > 12b5f34 > > Diff: https://reviews.apache.org/r/31537/diff/ > > > Testing > ------- > > mvn clean test > > > Thanks, > > Vitalyi Brodetskyi > >
