----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31557/#review74560 -----------------------------------------------------------
Ship it! This looks good as long as it doesn't break the resolution of bug AMBARI-9739. ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelper.java <https://reviews.apache.org/r/31557/#comment121162> `serviceComponentHosts` should be copied before being altered as to not loose items for downstream operations. ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelper.java <https://reviews.apache.org/r/31557/#comment121163> There is no need to copy `hostsWithValidKerberosClient` here. It shoudn't get changed in `addDistributeKeytabFilesStage` - Robert Levas On Feb. 27, 2015, 2:34 p.m., Vitalyi Brodetskyi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31557/ > ----------------------------------------------------------- > > (Updated Feb. 27, 2015, 2:34 p.m.) > > > Review request for Ambari, Dmitro Lisnichenko and Robert Levas. > > > Bugs: AMBARI-9837 > https://issues.apache.org/jira/browse/AMBARI-9837 > > > Repository: ambari > > > Description > ------- > > Install cluster > Create Slider View (also create some apps). > Enable security > Try to disable security > It fails on Services Start (DataNode start) > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelper.java > e562497 > > Diff: https://reviews.apache.org/r/31557/diff/ > > > Testing > ------- > > mvn clean test > > > Thanks, > > Vitalyi Brodetskyi > >
