----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31600/#review74796 -----------------------------------------------------------
* Why do we call "setup_spark" on Stop * Can we remove the comments to the call to the older version of "setup_spark" and "self.configure"? * Can you add a comment in configure() that self.configure() is not called from .start() or .install(). This is a departure from standard practice so add a comment so that folks changing self.configure() should not assume that it will get called by start() - Sumit Mohanty On March 2, 2015, 5:49 p.m., Gautam Borad wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31600/ > ----------------------------------------------------------- > > (Updated March 2, 2015, 5:49 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Giridharan Kesavan, and > Yusaku Sako. > > > Bugs: AMBARI-9811 > https://issues.apache.org/jira/browse/AMBARI-9811 > > > Repository: ambari > > > Description > ------- > > Spark client install is trying to create HDFS directory during the INSTALL > phase. This should be done in the START phase. > Commenting out dir creation for time being. Will provide a better solution as > soon as possible. > > > Diffs > ----- > > > ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/job_history_server.py > 05fd604 > > ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/setup_spark.py > 8df5378 > > ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/spark_client.py > b0cb39d > ambari-server/src/main/resources/stacks/HDP/2.2/role_command_order.json > 928caa8 > > Diff: https://reviews.apache.org/r/31600/diff/ > > > Testing > ------- > > NA > > > Thanks, > > Gautam Borad > >
