----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31693/#review75228 -----------------------------------------------------------
Please add some tests to verify that calling from the ResourceProvider ends up doing the right thing. ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FinalizeUpgradeAction.java <https://reviews.apache.org/r/31693/#comment122193> No need to break this up. - Nate Cole On March 4, 2015, 2:34 p.m., Dmitro Lisnichenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31693/ > ----------------------------------------------------------- > > (Updated March 4, 2015, 2:34 p.m.) > > > Review request for Ambari. > > > Repository: ambari > > > Description > ------- > > Preview > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/api/services/ClusterStackVersionService.java > eb8a461 > > ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java > 9c8bcd7 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java > 0cf89a3 > > ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FinalizeUpgradeAction.java > d8e5e92 > > Diff: https://reviews.apache.org/r/31693/diff/ > > > Testing > ------- > > > Thanks, > > Dmitro Lisnichenko > >
