----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31766/#review75336 -----------------------------------------------------------
Ship it! Ship It! - Vitalyi Brodetskyi On Березень 5, 2015, 3:07 після полудня, Andrew Onischuk wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31766/ > ----------------------------------------------------------- > > (Updated Березень 5, 2015, 3:07 після полудня) > > > Review request for Ambari and Vitalyi Brodetskyi. > > > Bugs: AMBARI-9943 > https://issues.apache.org/jira/browse/AMBARI-9943 > > > Repository: ambari > > > Description > ------- > > This is double permission restriction which we seems like haven't yet tested. > > The most common problem I see over the code that hardcore umask removes some x > bits. We didn't really need them until we were using root account, but now it > becomes a problem in multiple or more places. > > > Diffs > ----- > > ambari-agent/conf/unix/ambari-env.sh bf7ca55 > ambari-agent/src/test/python/resource_management/TestDirectoryResource.py > fe64400 > ambari-agent/src/test/python/resource_management/TestExecuteResource.py > 216fd1a > ambari-agent/src/test/python/resource_management/TestFileResource.py > 28fa610 > ambari-agent/src/test/python/resource_management/TestLinkResource.py > cdb6061 > > ambari-agent/src/test/python/resource_management/TestPropertiesFileResource.py > bdb64de > ambari-agent/src/test/python/resource_management/TestXmlConfigResource.py > 4affd31 > ambari-common/src/main/python/resource_management/core/providers/system.py > ac63b21 > ambari-common/src/main/python/resource_management/core/sudo.py ae21f84 > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py > 64bcebc > > ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/scripts/shared_initialization.py > 745402a > > ambari-server/src/test/python/stacks/2.0.6/hooks/before-INSTALL/test_before_install.py > e038ddf > ambari-server/src/test/python/stacks/2.1/HIVE/test_hive_metastore.py > 990eac8 > > Diff: https://reviews.apache.org/r/31766/diff/ > > > Testing > ------- > > mvn clean test > > > Thanks, > > Andrew Onischuk > >
