----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31866/#review75787 -----------------------------------------------------------
Ship it! Ship It! - Tom Beerbower On March 9, 2015, 7:31 p.m., Jonathan Hurley wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31866/ > ----------------------------------------------------------- > > (Updated March 9, 2015, 7:31 p.m.) > > > Review request for Ambari, Nate Cole and Tom Beerbower. > > > Bugs: AMBARI-9987 > https://issues.apache.org/jira/browse/AMBARI-9987 > > > Repository: ambari > > > Description > ------- > > You can't see the units for DataNode Health Summary alert, and there is no > hovertext so there is no way for a user to see this days "DataNode(s)". > > Suggest renaming the units on this alert to "DNs" as a quick fix. > > *** Also, I'm sick of my unit tests failing b/c we're using the version file > from target/version. This should be an explicit test resource, so I added it > *** > > > Diffs > ----- > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/alerts.json > 8f55cde > > ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/HDFS/alerts.json > 95464b7 > > ambari-server/src/test/java/org/apache/ambari/server/api/services/AmbariMetaInfoTest.java > 0d944ab > > ambari-server/src/test/java/org/apache/ambari/server/api/services/KerberosServiceMetaInfoTest.java > 8a4616a > > ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java > adf562b > > ambari-server/src/test/java/org/apache/ambari/server/orm/InMemoryDefaultTestModule.java > 621caba > > ambari-server/src/test/java/org/apache/ambari/server/orm/JdbcPropertyTest.java > 2c229cb > > ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AuthorizationTestModule.java > 969615f > > ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AuthorizationTestModuleForLdapDNWithSpace.java > ba824a4 > > ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeTest.java > 44bd204 > ambari-server/src/test/resources/version PRE-CREATION > > Diff: https://reviews.apache.org/r/31866/diff/ > > > Testing > ------- > > mvn clean test > > > Thanks, > > Jonathan Hurley > >
