----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31911/#review75983 -----------------------------------------------------------
Ship it! Ship It! ambari-server/src/main/python/ambari-server.py <https://reviews.apache.org/r/31911/#comment123345> Let's avoid confusion by renaming SET_CURRENT to SET_CURRENT_ACTIOn ambari-server/src/main/python/ambari_server/setupActions.py <https://reviews.apache.org/r/31911/#comment123347> Let's append _ACTION ambari-server/src/test/python/TestUpgradeHelper.py <https://reviews.apache.org/r/31911/#comment123348> How much work is it to fix the unit test? - Alejandro Fernandez On March 10, 2015, 9:22 p.m., Dmitro Lisnichenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31911/ > ----------------------------------------------------------- > > (Updated March 10, 2015, 9:22 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Nate Cole, > and Tom Beerbower. > > > Bugs: AMBARI-10017 > https://issues.apache.org/jira/browse/AMBARI-10017 > > > Repository: ambari > > > Description > ------- > > This patch provides improvements for previously committed jira > AMBARI-9964 Rolling Upgrade: Expose FinalizeUpgradeAction to API or force > transition from UPGRADED to CURRENT for cluster_version via API request > > Implemented a helper call from ambari-server like so: > > ambari-server set-current {ClusterName} {VersionDisplayName} > Enter Ambari login: X > Enter Ambari password: X > > made sure to handle: > 1) Ambari server might be http or https > 2) Ambari server port > 3) Ambari server might not be running > > Also removed parts of previously committed patch that provided this > functionality through upgradeHelper > > Patch needs to come in ASAP, so I created a separate jira for unit test > coverage/fixing any comments if any > > > Diffs > ----- > > ambari-server/sbin/ambari-server 168790b > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java > e93e653 > ambari-server/src/main/python/ambari-server.py 4adac67 > ambari-server/src/main/python/ambari_server/serverUpgrade.py bcb6dca > ambari-server/src/main/python/ambari_server/serverUtils.py 539f8f5 > ambari-server/src/main/python/ambari_server/setupActions.py cd5234b > ambari-server/src/main/python/ambari_server/setupSecurity.py 18e703e > ambari-server/src/main/python/upgradeHelper.py 2426d69 > ambari-server/src/test/python/TestUpgradeHelper.py 8e88883 > > Diff: https://reviews.apache.org/r/31911/diff/ > > > Testing > ------- > > [INFO] > ------------------------------------------------------------------------ > [INFO] Reactor Summary: > [INFO] > [INFO] Ambari Views ...................................... SUCCESS [3.323s] > [INFO] Ambari Metrics Common ............................. SUCCESS [1.499s] > [INFO] Ambari Server ..................................... SUCCESS > [36:49.494s] > [INFO] Ambari Agent ...................................... SUCCESS [16.115s] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 37:11.222s > [INFO] Finished at: Tue Mar 10 23:16:40 EET 2015 > [INFO] Final Memory: 36M/345M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Dmitro Lisnichenko > >
