-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32144/#review76695
-----------------------------------------------------------

Ship it!



ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/params.py
<https://reviews.apache.org/r/32144/#comment124324>

    Can you explicitly import substitute_vars ?


- Alejandro Fernandez


On March 17, 2015, 1:36 a.m., Sid Wagle wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32144/
> -----------------------------------------------------------
> 
> (Updated March 17, 2015, 1:36 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Dmytro Sen, Mahadev Konar, 
> and Myroslav Papirkovskyy.
> 
> 
> Bugs: AMBARI-10096
>     https://issues.apache.org/jira/browse/AMBARI-10096
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> - Slow queries on client side:
> {code}
> 16:30:37,833  INFO [162596193@qtp-226773415-1526] 
> HBaseTimelineMetricStore:156 - Query: Condition{metricNames=[cpu_num, 
> load_one, proc_run], hostname='null', appId='HOST', instanceId='null', 
> startTime=1
> 426519751, endTime=1426523351, limit=null, grouped=true, orderBy=[], 
> noLimit=false}, startTime: Mon Mar 16 16:30:26 UTC 2015, Query end time:  Mon 
> Mar 16 16:30:37 UTC 2015, seconds taken: 11
> {code}
> - Spill files present on disk.
> 
> 
> Diffs
> -----
> 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/PhoenixHBaseAccessor.java
>  e40a115 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-hbase-site.xml
>  940d7af 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-site.xml
>  d3da1af 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/ams.py
>  27d24de 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/hbase.py
>  f488308 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/params.py
>  77b5ec1 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py 
> 6ee60cf 
>   ambari-server/src/test/python/stacks/2.2/common/test_stack_advisor.py 
> 2dafb67 
> 
> Diff: https://reviews.apache.org/r/32144/diff/
> 
> 
> Testing
> -------
> 
> ----------------------------------------------------------------------
> Ran 234 tests in 6.792s
> 
> OK
> ----------------------------------------------------------------------
> Total run:613
> Total errors:0
> Total failures:0
> OK
> 
> 
> Thanks,
> 
> Sid Wagle
> 
>

Reply via email to