> On March 17, 2015, 7:25 a.m., Nate Cole wrote: > > ambari-agent/src/main/python/ambari_agent/alerts/web_alert.py, lines 95-97 > > <https://reviews.apache.org/r/32148/diff/1/?file=897262#file897262line95> > > > > Hmm, I thought we agreed tuples stay in parentheses for "tuple > > obviousness" - but ok.
Yeah, I forgot to put them back in; PyCharm was being annoying and not ignoring the warning. I put them back :) - Jonathan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32148/#review76726 ----------------------------------------------------------- On March 16, 2015, 10:45 p.m., Jonathan Hurley wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32148/ > ----------------------------------------------------------- > > (Updated March 16, 2015, 10:45 p.m.) > > > Review request for Ambari, Alejandro Fernandez and Nate Cole. > > > Bugs: AMBARI-10099 > https://issues.apache.org/jira/browse/AMBARI-10099 > > > Repository: ambari > > > Description > ------- > > When a web alert is triggered, whether or not a connection is made, the error > messages always indicates an invalid socket. This can be very confusing, > especially when the actual HTTP error code is being masked by the CRITICAL > text. > > This will clearly separate out the HTTP error codes from connection problems. > > > Diffs > ----- > > ambari-agent/src/main/python/ambari_agent/alerts/web_alert.py 2db4996 > ambari-agent/src/test/python/ambari_agent/TestAlerts.py 3133c57 > > ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/alerts.json > e028ed5 > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/alerts.json > d5dccbf > > ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/alerts.json > 01d9148 > > ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/alerts.json > 002fd07 > ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/alerts.json > fe1ae8a > > ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/HDFS/alerts.json > ac5ab37 > > ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/OOZIE/alerts.json > 17c2b23 > > ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/YARN/alerts.json > aeabc93 > > Diff: https://reviews.apache.org/r/32148/diff/ > > > Testing > ------- > > Triggered a WEB alert between OK, WARNING, and CRITICAL. > > [INFO] Rat check: Summary of files. Unapproved: 0 unknown: 0 generated: 0 > approved: 124 licence. > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 12.476 s > [INFO] Finished at: 2015-03-16T22:42:00-04:00 > [INFO] Final Memory: 8M/81M > > > Thanks, > > Jonathan Hurley > >
