----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32212/#review76936 -----------------------------------------------------------
Ship it! Ship It! - Nate Cole On March 18, 2015, 4:10 p.m., Jonathan Hurley wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32212/ > ----------------------------------------------------------- > > (Updated March 18, 2015, 4:10 p.m.) > > > Review request for Ambari and Nate Cole. > > > Bugs: AMBARI-10126 > https://issues.apache.org/jira/browse/AMBARI-10126 > > > Repository: ambari > > > Description > ------- > > When the Ambari agent starts, the alerts scheduler loads all definitions from > the cache definitions.json but doesn't start the scheduler. When the first > heartbeat arrives, the jobs are re-added and the scheduler is started. > However, job reconciliation doesn't happen until after the schedule is > started, so there are duplicates of every job scheduled. > > > Diffs > ----- > > ambari-agent/src/main/python/ambari_agent/Controller.py eeca4c2 > > Diff: https://reviews.apache.org/r/32212/diff/ > > > Testing > ------- > > Started agent with and without definitions.json and observed correct job > scheduling. Updated a job and observed the correct unscheduling and > re-scheduling of said job. > > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 41.081 s > [INFO] Finished at: 2015-03-18T16:09:58-04:00 > [INFO] Final Memory: 10M/81M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Jonathan Hurley > >
