----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32247/#review77075 -----------------------------------------------------------
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/metainfo.xml <https://reviews.apache.org/r/32247/#comment124911> There's a new concept called, <versionAdvertised>true|false</versionAdvertised> If NFS_GATEWAY is part of hdp-select, it should have a value of true. ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_nfsgateway.py <https://reviews.apache.org/r/32247/#comment124912> Only need to import Directory, as opposed to * ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/nfsgateway.py <https://reviews.apache.org/r/32247/#comment124913> Prefer to use explicit imports. ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/nfsgateway.py <https://reviews.apache.org/r/32247/#comment124914> During a rolling restart, it will need to call hdp-select on its new version before the service starts. Take a look at other components in HDFS for an example. ambari-server/src/test/python/stacks/2.0.6/HDFS/test_nfsgateway.py <https://reviews.apache.org/r/32247/#comment124915> Nice, thanks for adding a unit test. - Alejandro Fernandez On March 19, 2015, 5:56 p.m., Brandon Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32247/ > ----------------------------------------------------------- > > (Updated March 19, 2015, 5:56 p.m.) > > > Review request for Ambari and Alejandro Fernandez. > > > Bugs: AMBARI-9224 > https://issues.apache.org/jira/browse/AMBARI-9224 > > > Repository: ambari > > > Description > ------- > > Ambari-9224: Add HDFS-NFS gateway as a new component to HDFS in Ambari stack > > > Diffs > ----- > > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/metainfo.xml > ba9688a > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_nfsgateway.py > PRE-CREATION > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/nfsgateway.py > PRE-CREATION > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/status_params.py > 6ae9b66 > ambari-server/src/test/python/stacks/2.0.6/HDFS/test_nfsgateway.py > PRE-CREATION > ambari-web/app/data/HDP2/config_mapping.js 1104ceb > > Diff: https://reviews.apache.org/r/32247/diff/ > > > Testing > ------- > > build passed on Apache. > unit tests passed in my local run. > > > Thanks, > > Brandon Li > >
