> On Март 19, 2015, 5:43 п.п., Sid Wagle wrote: > > ambari-server/src/main/java/org/apache/ambari/server/stack/StackModule.java, > > line 613 > > <https://reviews.apache.org/r/32218/diff/3/?file=899903#file899903line613> > > > > Does this call need to be thread safe, to avoid Concurrentmodification? > > Dmytro Sen wrote: > It's executed only once during server start in a single thread.
I can replace it with a foreach loop - Dmytro ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32218/#review77071 ----------------------------------------------------------- On Март 19, 2015, 4:59 п.п., Dmytro Sen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32218/ > ----------------------------------------------------------- > > (Updated Март 19, 2015, 4:59 п.п.) > > > Review request for Ambari, Myroslav Papirkovskyy, Srimanth Gunturi, and Sid > Wagle. > > > Bugs: AMBARI-10123 > https://issues.apache.org/jira/browse/AMBARI-10123 > > > Repository: ambari > > > Description > ------- > > YARN properties should show up in the API as > { > "href" : > "http://c6401:8080/api/v1/stacks/HDP/versions/2.2/services/YARN/configurations/yarn.scheduler.minimum-allocation-mb";, > "StackConfigurations" : { > "final" : "false", > "property_description" : "The minimum allocation for every container > request", > "property_name" : "yarn.scheduler.minimum-allocation-mb", > "property_type" : [ ], > "property_value" : "512",// Recommended > "property_value_attributes": { > "type": "int", > "minimum": "512", > "maximum": "10240", > "unit": "MB" > }, > "property_depended_by": [ > { > "property_type": "hive-site", > "property_name": "hive.tez.container.size" > }, > { > "property_type": "mapred-site", > > property_depends_on in the stack-definition should be transformed inversely > to generate property_depended_by. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/controller/StackConfigurationResponse.java > 9a7831e > > ambari-server/src/main/java/org/apache/ambari/server/controller/StackLevelConfigurationResponse.java > 151ce07 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackConfigurationResourceProvider.java > 4abf3d2 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackLevelConfigurationResourceProvider.java > 1091bc7 > ambari-server/src/main/java/org/apache/ambari/server/stack/StackModule.java > 4181293 > > ambari-server/src/main/java/org/apache/ambari/server/state/PropertyDependencyInfo.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/state/PropertyInfo.java > e26b48f > > ambari-server/src/main/java/org/apache/ambari/server/state/ValueAttributesInfo.java > PRE-CREATION > > ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/configuration-mapred/mapred-site.xml > 7955cb2 > > ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/configuration/yarn-site.xml > 3df629d > ambari-server/src/main/resources/properties.json cdb2bd6 > > ambari-server/src/main/resources/stacks/HDP/2.2/services/YARN/configuration/yarn-site.xml > 94b5304 > > ambari-server/src/test/java/org/apache/ambari/server/api/services/AmbariMetaInfoTest.java > c7878db > > ambari-server/src/test/java/org/apache/ambari/server/state/PropertyInfoTest.java > e8a2a8d > > ambari-server/src/test/resources/stacks/HDP/2.0.6/services/YARN/configuration/yarn-site.xml > 59b5245 > > Diff: https://reviews.apache.org/r/32218/diff/ > > > Testing > ------- > > all tests passed > > > Thanks, > > Dmytro Sen > >
