-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32309/
-----------------------------------------------------------
Review request for Ambari and Andriy Babiichuk.
Bugs: ambari-10158
https://issues.apache.org/jira/browse/ambari-10158
Repository: ambari
Description
-------
Multiple configs have time interval which is saved as milliseconds. However we
need to use the theme to create a time-interval-spinner control which will
allow user to set milliseconds using a more understandable hours/mins/seconds
spinners.
The configuration will be defined in the stack as
{code}
{
"href" :
"http://c6401:8080/api/v1/stacks/HDP/versions/2.2/services/HBASE/configurations/hbase.hregion.majorcompaction";,
"StackConfigurations" : {
"final" : "false",
"property_description" : "Time between major compactions",
"property_name" : "hbase.hregion.majorcompaction",
"property_type" : [ ],
"property_value" : "604800000",// Recommended
"property_value_attributes": {
"type": "int",
"minimum": "0",
"maximum": "2592000000", // 30 days
"unit": "milliseconds",
},
"service_name" : "HBASE",
"stack_name" : "HDP",
"stack_version" : "2.2",
"type" : "hbase-site.xml"
}
}
{code}
The theme will have the widget defined as
{code}
"configs": [
{
"config": "hive-site/hive.exec.orc.default.compress",
"widget": {
"type": "time-interval-spinner",
"units": [
{
"unit": "days,hours,minutes"
}
]
}
}
]
{code}
Diffs
-----
ambari-web/app/assets/test/tests.js 25b04f2
ambari-web/app/messages.js 1730b62
ambari-web/app/styles/widgets.less 6065a3f
ambari-web/app/templates/common/configs/widgets/time_interval_spinner.hbs
PRE-CREATION
ambari-web/app/templates/common/form/spinner_input.hbs PRE-CREATION
ambari-web/app/views.js 090d4ba
ambari-web/app/views/common/configs/widgets/time_interval_spinner_view.js
PRE-CREATION
ambari-web/app/views/common/form/spinner_input_view.js PRE-CREATION
ambari-web/test/views/common/configs/widgets/time_interval_spinner_view_test.js
PRE-CREATION
Diff: https://reviews.apache.org/r/32309/diff/
Testing
-------
5613 tests complete (11 seconds)
68 tests pending
Thanks,
Oleg Nechiporenko
