-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32483/
-----------------------------------------------------------

Review request for Ambari and Nate Cole.


Bugs: AMBARI-10197
    https://issues.apache.org/jira/browse/AMBARI-10197


Repository: ambari


Description
-------

It looks like there is a circular dependency with the mock libraries and how we 
are calling Controller functions. Mocking out the values outside of the `with` 
statement. Seems to fix the problem.


Diffs
-----

  ambari-agent/src/test/python/ambari_agent/TestController.py 0c9144e 
  ambari-agent/src/test/python/ambari_agent/TestHardware.py 9bffaf6 
  ambari-agent/src/test/python/ambari_agent/TestHostInfo.py 5ea67ce 
  ambari-agent/src/test/python/ambari_agent/TestRegistration.py b7a7f89 

Diff: https://reviews.apache.org/r/32483/diff/


Testing
-------

----------------------------------------------------------------------
Ran 315 tests in 9.125s

OK
[INFO]
[INFO] --- apache-rat-plugin:0.11:check (default) @ ambari-agent ---
[INFO] 51 implicit excludes (use -debug for more details).
[INFO] Exclude: src/test/python/tmp_hostcheck.result
[INFO] Exclude: src/examples/*
[INFO] Exclude: src/test/python/dummy*.txt
[INFO] Exclude: src/test/python/ambari_agent/dummy_files/*
[INFO] Exclude: src/test/python/ambari_agent/dummy*.txt
[INFO] Exclude: src/main/python/ambari_agent/imports.txt
[INFO] Exclude: src/main/python/ambari_agent/apscheduler/**
[INFO] Exclude: etc/sudoers.d/ambari-agent
[INFO] Exclude: **/*.erb
[INFO] Exclude: **/*.json
[INFO] Exclude: **/*.pydevproject
[INFO] Exclude: **/*.wxs
[INFO] 218 resources included (use -debug for more details)
Warning:  org.apache.xerces.jaxp.SAXParserImpl$JAXPSAXParser: Property 
'http://www.oracle.com/xml/jaxp/properties/entityExpansionLimit' is not 
recognized.
Warning:  org.apache.xerces.parsers.SAXParser: Feature 
'http://javax.xml.XMLConstants/feature/secure-processing' is not recognized.
Warning:  org.apache.xerces.parsers.SAXParser: Property 
'http://www.oracle.com/xml/jaxp/properties/entityExpansionLimit' is not 
recognized.
[INFO] Rat check: Summary of files. Unapproved: 0 unknown: 0 generated: 0 
approved: 124 licence.
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 12.648 s
[INFO] Finished at: 2015-03-25T12:27:27-04:00
[INFO] Final Memory: 8M/81M


Thanks,

Jonathan Hurley

Reply via email to