----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32537/#review77911 -----------------------------------------------------------
Ship it! Ship It! - Jayush Luniya On March 26, 2015, 4:18 p.m., Florian Barca wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32537/ > ----------------------------------------------------------- > > (Updated March 26, 2015, 4:18 p.m.) > > > Review request for Ambari, Artem Baranchuk, Alejandro Fernandez, Jayush > Luniya, and Robert Levas. > > > Bugs: AMBARI-10220 > https://issues.apache.org/jira/browse/AMBARI-10220 > > > Repository: ambari > > > Description > ------- > > Part 1 of 2: Fixed constraint definitions in the SQL Server db creation > script. > > Part 2 will address sqlcmd return value handling. > > > Diffs > ----- > > ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql > 330945c22191d66f78826f67f6d41414b825a9c0 > ambari-server/src/main/resources/Ambari-DDL-SQLServer-DROP.sql > 87029a2c0a2425374dafa059b79f69e01c00cf23 > > Diff: https://reviews.apache.org/r/32537/diff/ > > > Testing > ------- > > mvn clean test > ran ambari-server.cmd setup --verbose -> no message, db created ok > > > Thanks, > > Florian Barca > >
