----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32572/#review78048 -----------------------------------------------------------
Ship it! Ship It! - Vitalyi Brodetskyi On Березень 27, 2015, 2:24 після полудня, Andrew Onischuk wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32572/ > ----------------------------------------------------------- > > (Updated Березень 27, 2015, 2:24 після полудня) > > > Review request for Ambari and Vitalyi Brodetskyi. > > > Bugs: AMBARI-10238 > https://issues.apache.org/jira/browse/AMBARI-10238 > > > Repository: ambari > > > Description > ------- > > upgradeHelper.py should be covered by unitests. Initial unittest module > already created "ambari/ambari-server/src/test/python/TestUpgradeHelper.py" > (will come with patch). > > This task is a re-factor task of previously existed module > TestUpgradeScript_HDP2.py, but as upgradeHelper.py was re-factored, unit tests > should be re-factored too. > > > Diffs > ----- > > ambari-server/src/main/python/upgradeHelper.py 11292e9 > ambari-server/src/test/python/TestUpgradeHelper.py 2f47620 > > Diff: https://reviews.apache.org/r/32572/diff/ > > > Testing > ------- > > mvn clean test > > > Thanks, > > Andrew Onischuk > >
