----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32580/#review78110 -----------------------------------------------------------
Ship it! Ship It! - Nate Cole On March 27, 2015, 1:32 p.m., Jonathan Hurley wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32580/ > ----------------------------------------------------------- > > (Updated March 27, 2015, 1:32 p.m.) > > > Review request for Ambari, Alejandro Fernandez and Nate Cole. > > > Bugs: AMBARI-10249 > https://issues.apache.org/jira/browse/AMBARI-10249 > > > Repository: ambari > > > Description > ------- > > Add a logger so that alert state changes are captured to a persistent file on > disk. > > Output is similar to: > ``` > [CRITICAL] [HDFS] [namenode_hdfs_blocks_health] (NameNode Blocks Health) > Total Blocks:[100], Missing Blocks:[6] > ``` > > > Diffs > ----- > > ambari-server/conf/log4j.properties a1818ce > ambari-server/conf/unix/log4j.properties 294dd67 > ambari-server/conf/windows/log4j.properties e0c602d > ambari-server/src/main/conf/log4j.properties deb9dd9 > > ambari-server/src/main/java/org/apache/ambari/server/events/listeners/alerts/AlertStateChangedListener.java > d84c449 > > Diff: https://reviews.apache.org/r/32580/diff/ > > > Testing > ------- > > Built RPM to ensure removing an old log4j.properties won't hurt anything. > Verified the log statements. > > > Thanks, > > Jonathan Hurley > >
