> On March 30, 2015, 10:34 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java, > > line 1010 > > <https://reviews.apache.org/r/32646/diff/1/?file=909802#file909802line1010> > > > > I'm probably not understanding how the differences between OS type and > > OS family are stored here; but what happens above if `gsonList = > > gson.toJsonTree(repos.get(family));` is used to build the JSON. You're > > still only comparing `getOsType()` here. Is that a problem? > > Nate Cole wrote: > Hmm, I'll see if I can reproduce that case.
Ok, checked into it - and the family is the one that ends up being called. We don't have osType-specific URLs anymore (we used to). We have that family/osType check there so that when people would upgrade, the code would continue to work. The java code was never changed to indicate that osType is really family, so when you see osType on a repo url, it's really the "family" value. Sheesh. Patch is still valid. - Nate ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32646/#review78318 ----------------------------------------------------------- On March 30, 2015, 7:07 p.m., Nate Cole wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32646/ > ----------------------------------------------------------- > > (Updated March 30, 2015, 7:07 p.m.) > > > Review request for Ambari, Alejandro Fernandez and Jonathan Hurley. > > > Bugs: AMBARI-10288 > https://issues.apache.org/jira/browse/AMBARI-10288 > > > Repository: ambari > > > Description > ------- > > Fix for a previous issue (AMBARI-10189) was only temporary. This patch > addresses the issue correctly. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java > 1df7284 > > ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FinalizeUpgradeAction.java > 586e98c > > ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/UpgradeActionTest.java > 1c0e195 > > Diff: https://reviews.apache.org/r/32646/diff/ > > > Testing > ------- > > Manual > Changed unit test > > Tests run: 2802, Failures: 0, Errors: 0, Skipped: 15 > > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 20:59.645s > [INFO] Finished at: Mon Mar 30 18:50:50 EDT 2015 > [INFO] Final Memory: 41M/623M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Nate Cole > >
