> On March 31, 2015, 11:45 p.m., Yusaku Sako wrote: > > ambari-web/app/data/service_graph_config.js, line 100 > > <https://reviews.apache.org/r/32706/diff/2/?file=911737#file911737line100> > > > > Spacing looks non standard.
Spacing appears to be incorrect in the attached patch. But the same in my IDE (Intellij Idea) shows 2 space indentation which is a standard for amabri-web code. Can you please apply the patch in your environment and confirm that spacing standards are met or not by the patch ? > On March 31, 2015, 11:45 p.m., Yusaku Sako wrote: > > ambari-web/app/messages.js, line 2465 > > <https://reviews.apache.org/r/32706/diff/2/?file=911738#file911738line2465> > > > > as a "single number" will fix in next revision of the patch > On March 31, 2015, 11:45 p.m., Yusaku Sako wrote: > > ambari-web/app/messages.js, line 2470 > > <https://reviews.apache.org/r/32706/diff/2/?file=911738#file911738line2470> > > > > IMO, it's better to say "want" or "wish" rather than "plan". Plan > > sounds too heavy. will incorportae this suggestion in next revision of the patch > On March 31, 2015, 11:45 p.m., Yusaku Sako wrote: > > ambari-web/app/messages.js, line 2472 > > <https://reviews.apache.org/r/32706/diff/2/?file=911738#file911738line2472> > > > > Let's use the term "parentheses" () as opposed to "brackets" []. will fix in next revision of the patch - Jaimin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32706/#review78434 ----------------------------------------------------------- On March 31, 2015, 11:34 p.m., Jaimin Jetly wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32706/ > ----------------------------------------------------------- > > (Updated March 31, 2015, 11:34 p.m.) > > > Review request for Ambari, Xi Wang and Yusaku Sako. > > > Bugs: AMBARI-10304 > https://issues.apache.org/jira/browse/AMBARI-10304 > > > Repository: ambari > > > Description > ------- > > As a part of this ticket create the wizard flow: launching of the wizard, > navigation of the wizard, handling browser refreshes by storing required data > on seperate pages in browser local db > > > Diffs > ----- > > ambari-web/app/controllers.js 56b144d > ambari-web/app/controllers/main/service/info/summary.js 1eec9d1 > ambari-web/app/controllers/main/service/widgets/create/step1_controller.js > PRE-CREATION > ambari-web/app/controllers/main/service/widgets/create/step2_controller.js > PRE-CREATION > ambari-web/app/controllers/main/service/widgets/create/step3_controller.js > PRE-CREATION > ambari-web/app/controllers/main/service/widgets/create/wizard_controller.js > PRE-CREATION > ambari-web/app/data/service_graph_config.js 36da518 > ambari-web/app/messages.js 86093fc > ambari-web/app/models/widget.js e00cd05 > ambari-web/app/routes/add_widget.js PRE-CREATION > ambari-web/app/routes/main.js 739f9c9 > ambari-web/app/templates/main/service/info/summary.hbs 92f7cbd > ambari-web/app/templates/main/service/widgets/create/step1.hbs PRE-CREATION > ambari-web/app/templates/main/service/widgets/create/step2.hbs PRE-CREATION > ambari-web/app/templates/main/service/widgets/create/step3.hbs PRE-CREATION > ambari-web/app/templates/main/service/widgets/create/wizard.hbs > PRE-CREATION > ambari-web/app/utils/db.js e5f9bb7 > ambari-web/app/views.js 6a29279 > ambari-web/app/views/main/service/info/summary.js f4e123d > ambari-web/app/views/main/service/widgets/create/step1_view.js PRE-CREATION > ambari-web/app/views/main/service/widgets/create/step2_view.js PRE-CREATION > ambari-web/app/views/main/service/widgets/create/step3_view.js PRE-CREATION > ambari-web/app/views/main/service/widgets/create/wizard_view.js > PRE-CREATION > > Diff: https://reviews.apache.org/r/32706/diff/ > > > Testing > ------- > > Tested on the ambari-web brunch server. > ambari-web unit test result with the patch: > > 5752 tests complete (10 seconds) > 68 tests pending > > > Thanks, > > Jaimin Jetly > >
