----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32730/#review78556 -----------------------------------------------------------
ambari-server/src/main/resources/common-services/MAHOUT/1.0.0.2.3/package/scripts/mahout.py <https://reviews.apache.org/r/32730/#comment127419> log4j_props will NEVER be None, please use is_empty(log4j_props) for checking if it was sent via configurations or not ambari-server/src/test/python/stacks/2.3/MAHOUT/test_mahout_client.py <https://reviews.apache.org/r/32730/#comment127418> Let's replace this big hardcoded line by self.getConfig()['configurations']['mahout-log4j']['content'] this what we do in most cases not hardcode such a big things in tests. - Andrew Onischuk On April 1, 2015, 5:35 p.m., Vitalyi Brodetskyi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32730/ > ----------------------------------------------------------- > > (Updated April 1, 2015, 5:35 p.m.) > > > Review request for Ambari and Andrew Onischuk. > > > Bugs: AMBARI-10315 > https://issues.apache.org/jira/browse/AMBARI-10315 > > > Repository: ambari > > > Description > ------- > > . > > > Diffs > ----- > > > ambari-server/src/main/resources/common-services/MAHOUT/1.0.0.2.3/configuration/mahout-log4j.xml > PRE-CREATION > > ambari-server/src/main/resources/common-services/MAHOUT/1.0.0.2.3/metainfo.xml > 15ede51 > > ambari-server/src/main/resources/common-services/MAHOUT/1.0.0.2.3/package/scripts/mahout.py > ba10035 > > ambari-server/src/main/resources/common-services/MAHOUT/1.0.0.2.3/package/scripts/params.py > 8efea99 > ambari-server/src/test/python/stacks/2.3/MAHOUT/test_mahout_client.py > b74c4e4 > ambari-server/src/test/python/stacks/2.3/configs/default.json 37c69d5 > > Diff: https://reviews.apache.org/r/32730/diff/ > > > Testing > ------- > > mvn clean test > > > Thanks, > > Vitalyi Brodetskyi > >
