> On April 1, 2015, 5:45 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog210.java, > > line 292 > > <https://reviews.apache.org/r/32741/diff/1-2/?file=912684#file912684line292> > > > > I believe the constraint name also has to change in the *.sql files.
Thanks for the review! - Jonathan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32741/#review78599 ----------------------------------------------------------- On April 1, 2015, 5:40 p.m., Jonathan Hurley wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32741/ > ----------------------------------------------------------- > > (Updated April 1, 2015, 5:40 p.m.) > > > Review request for Ambari, Nate Cole and Tom Beerbower. > > > Bugs: AMBARI-10301 > https://issues.apache.org/jira/browse/AMBARI-10301 > > > Repository: ambari > > > Description > ------- > > A new table should be created that contains the stack information for every > stack defined on the file system of Ambari Server. > > ||column||type||description|| > |stack_id|int|PK| > |stack_name|varchar|stack name, e.g. 'HDP'| > |stack_version|varchar|stack version, e.g. '2.2'| > > When Ambari starts up, the server should resolve available stacks and their > versions on the filesystem with the records available in the new stack table. > This concept is similar in design to how Alert Definitions are resolved on > startup. > > Most of the work here was in changing the StackManager to be injectible so it > has access to things like DAOs > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java > 3e37c3c > > ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java > f6cf6a1 > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java > 9b340ee > > ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java > 9c8bcd7 > ambari-server/src/main/java/org/apache/ambari/server/orm/dao/StackDAO.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/StackEntity.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/StackEntity_.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/stack/StackManager.java > 33f1447 > > ambari-server/src/main/java/org/apache/ambari/server/stack/StackManagerFactory.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog210.java > 7bdfb4f > ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql e28edfd > ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 513d951 > ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 6361edb > ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql > 2121805 > ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 40b00d9 > ambari-server/src/main/resources/META-INF/persistence.xml 723fbc0 > > ambari-server/src/test/java/org/apache/ambari/server/actionmanager/TestActionDBAccessorImpl.java > 1cf58d3 > > ambari-server/src/test/java/org/apache/ambari/server/agent/AgentResourceTest.java > c12e737 > > ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatHandler.java > c9d8735 > > ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatMonitor.java > 718310c > > ambari-server/src/test/java/org/apache/ambari/server/api/services/AmbariMetaInfoTest.java > ec61af8 > > ambari-server/src/test/java/org/apache/ambari/server/api/services/KerberosServiceMetaInfoTest.java > fe006ea > > ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelperTest.java > 7684322 > > ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java > 31c315b > > ambari-server/src/test/java/org/apache/ambari/server/controller/BackgroundCustomCommandExecutionTest.java > 78355eb > > ambari-server/src/test/java/org/apache/ambari/server/controller/KerberosHelperTest.java > 5e71991 > > ambari-server/src/test/java/org/apache/ambari/server/controller/RefreshYarnCapacitySchedulerReleaseConfigTest.java > 2c927a3 > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProviderTest.java > 29677fc > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostStackVersionResourceProviderTest.java > a868234 > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/JMXHostProviderTest.java > 6491f8d > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StackArtifactResourceProviderTest.java > 1251d99 > > ambari-server/src/test/java/org/apache/ambari/server/events/listeners/upgrade/HostVersionOutOfSyncListenerTest.java > f2417bd > > ambari-server/src/test/java/org/apache/ambari/server/scheduler/ExecutionScheduleManagerTest.java > 80c07c8 > > ambari-server/src/test/java/org/apache/ambari/server/stack/StackManagerCommonServicesTest.java > 4e258e8 > > ambari-server/src/test/java/org/apache/ambari/server/stack/StackManagerMiscTest.java > 26d7826 > > ambari-server/src/test/java/org/apache/ambari/server/stack/StackManagerTest.java > 0f39b06 > > ambari-server/src/test/java/org/apache/ambari/server/state/ConfigGroupTest.java > 894126d > > ambari-server/src/test/java/org/apache/ambari/server/state/ConfigHelperTest.java > 61652d1 > > ambari-server/src/test/java/org/apache/ambari/server/state/RequestExecutionTest.java > 8759089 > > ambari-server/src/test/java/org/apache/ambari/server/state/ServiceComponentTest.java > c27e600 > ambari-server/src/test/java/org/apache/ambari/server/state/ServiceTest.java > ecfe403 > > ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeHelperTest.java > be39bc2 > > ambari-server/src/test/java/org/apache/ambari/server/state/alerts/AlertEventPublisherTest.java > 10535e6 > > ambari-server/src/test/java/org/apache/ambari/server/state/alerts/InitialAlertEventTest.java > 25611c9 > > ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterDeadlockTest.java > 7459bd3 > > ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterTest.java > e444828 > > ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClustersDeadlockTest.java > 3a2773f > > ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClustersTest.java > ebf742e > > ambari-server/src/test/java/org/apache/ambari/server/state/host/HostTest.java > cac7dd7 > > ambari-server/src/test/java/org/apache/ambari/server/state/stack/UpgradePackTest.java > b37c0a7 > > ambari-server/src/test/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostTest.java > 8ebf2ce > > ambari-server/src/test/java/org/apache/ambari/server/utils/TestStageUtils.java > 8b134c4 > > Diff: https://reviews.apache.org/r/32741/diff/ > > > Testing > ------- > > mvn clean test > > > Thanks, > > Jonathan Hurley > >
