> On April 2, 2015, 2:19 p.m., John Speidel wrote: > > Changes look good, please add a new unit test before merging.
When I apply only the change to the test stack descriptor to inherit from 2.0.6 the tests pass without the code change in ServiceModule so there is currently no test for the issue being fixed in this patch. Also, please specify any functional testing done and also include the output from the unit tests to the review prior to merging as per the Ambari commit guidelines. - John ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32724/#review78660 ----------------------------------------------------------- On April 1, 2015, 3:30 p.m., Andrew Onischuk wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32724/ > ----------------------------------------------------------- > > (Updated April 1, 2015, 3:30 p.m.) > > > Review request for Ambari, John Speidel and Myroslav Papirkovskyy. > > > Bugs: AMBARI-10275 > https://issues.apache.org/jira/browse/AMBARI-10275 > > > Repository: ambari > > > Description > ------- > > Navigate to the review page of the Ambari Install Wizard by selecting all > defaults in previous steps (Didn't select Accumulo), used stack2.3. > Configuration information is not loaded on the page as shown in the > attachment. Please help take a look > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/stack/ServiceModule.java > 1e4a773 > ambari-server/src/test/resources/stacks/HDP/2.0.6.1/metainfo.xml 07da411 > > Diff: https://reviews.apache.org/r/32724/diff/ > > > Testing > ------- > > mvn clean test > > > Thanks, > > Andrew Onischuk > >
