-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32793/
-----------------------------------------------------------

Review request for Ambari, Jaimin Jetly and Yusaku Sako.


Bugs: AMBARI-10338
    https://issues.apache.org/jira/browse/AMBARI-10338


Repository: ambari


Description
-------

Gauge: Threshold*
Number: Threshold, Unit
Graph: Graph Type*, Time Range*, Unit
Template: Unit

'*' field is require. 
Non-required field could be empty.
Need validation for each property.

Go to step3, the properties values entered in step2 is in 
{{controller.content.widgetProperties}}


Diffs
-----

  ambari-web/app/controllers/main/service/widgets/create/step2_controller.js 
2438a80 
  ambari-web/app/models.js e9de30f 
  ambari-web/app/models/widget.js 88a80e3 
  ambari-web/app/models/widget_property.js PRE-CREATION 
  ambari-web/app/styles/enhanced_service_dashboard.less 24e52a3 
  ambari-web/app/templates/main/service/widgets/create/step2.hbs 50f7b86 
  
ambari-web/app/templates/main/service/widgets/create/widget_property_threshold.hbs
 PRE-CREATION 
  ambari-web/app/views/main/service/widgets/create/step2_view.js 610e98c 

Diff: https://reviews.apache.org/r/32793/diff/


Testing
-------

5771 tests complete (10 seconds)
  78 tests pending


Thanks,

Xi Wang

Reply via email to