----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32804/#review78762 -----------------------------------------------------------
Great work Alejandro. I have a very minor nit and a general question. Thanks Venkat ambari-server/src/main/java/org/apache/ambari/server/view/HttpImpersonatorImpl.java <https://reviews.apache.org/r/32804/#comment127796> Minor nit - spaces ambari-server/src/main/java/org/apache/ambari/server/view/HttpImpersonatorImpl.java <https://reviews.apache.org/r/32804/#comment127797> Not sure if this can be made more generic. If there can be some generic header that can be explicitly specified for this purpose and we will check for that to set user name instead of looking for Falcon headers? - Venkat Ranganathan On April 3, 2015, 12:46 a.m., Alejandro Fernandez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32804/ > ----------------------------------------------------------- > > (Updated April 3, 2015, 12:46 a.m.) > > > Review request for Ambari, Sumit Mohanty, Tom Beerbower, Venkat Ranganathan, > and Yusaku Sako. > > > Bugs: AMBARI-10341 > https://issues.apache.org/jira/browse/AMBARI-10341 > > > Repository: ambari > > > Description > ------- > > Falcon View needs to use the HttpImpersonator interface in Ambari Views so it > can proxy using the header user.name > > HttpImpersonatorImpl.java should only allow this if the request headers > indicate it is for the Falcon View. > > > Diffs > ----- > > ambari-server/pom.xml 896a202 > > ambari-server/src/main/java/org/apache/ambari/server/view/HttpImpersonatorImpl.java > fe4e180 > > ambari-server/src/test/java/org/apache/ambari/server/view/HttpImpersonatorImplTest.java > 935b488 > ambari-views/pom.xml 8fcb5ae > ambari-views/src/main/java/org/apache/ambari/view/HttpImpersonator.java > 02ce101 > ambari-views/src/main/java/org/apache/ambari/view/ImpersonatorResponse.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/32804/diff/ > > > Testing > ------- > > Ran local unit tests in HttpImpersonatorImplTest.java passed. > > > Thanks, > > Alejandro Fernandez > >
