----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32865/#review78893 -----------------------------------------------------------
Ship it! Ship It! - Andrew Onischuk On April 4, 2015, 10:53 p.m., Tom Beerbower wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32865/ > ----------------------------------------------------------- > > (Updated April 4, 2015, 10:53 p.m.) > > > Review request for Ambari and Andrew Onischuk. > > > Bugs: AMBARI-10359 > https://issues.apache.org/jira/browse/AMBARI-10359 > > > Repository: ambari > > > Description > ------- > > With rack awareness, the topology script for needs to be generated prior to > HDFS and YARN services starting for the first time. > This is simply a matter of setting the command param refresh_topology=True > for the service START command from Ambari server. It is currently set for the > RESTART command. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java > cfc1d4e > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java > a3ede22 > > ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelperTest.java > ee56ea7 > > Diff: https://reviews.apache.org/r/32865/diff/ > > > Testing > ------- > > Manual tested install new cluster and verify that topology script is created > when services start. > > New unit test added. > > All tests pass ... > > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 35:06 min > [INFO] Finished at: 2015-04-04T18:34:15-04:00 > [INFO] Final Memory: 52M/697M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Tom Beerbower > >
