----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32803/#review78945 -----------------------------------------------------------
ambari-server/src/main/java/org/apache/ambari/server/api/resources/WidgetLayoutResourceDefinition.java <https://reviews.apache.org/r/32803/#comment128056> Possible null pointer for empty layouts? ambari-server/src/main/java/org/apache/ambari/server/api/resources/WidgetResourceDefinition.java <https://reviews.apache.org/r/32803/#comment128057> Since all widgets are cluster widgets, we should have href here as well, right? ambari-server/src/main/java/org/apache/ambari/server/orm/entities/WidgetEntity.java <https://reviews.apache.org/r/32803/#comment128058> We should change table name to reflect chnages we made to entity and call it widget. ambari-server/src/main/java/org/apache/ambari/server/orm/entities/WidgetLayoutEntity.java <https://reviews.apache.org/r/32803/#comment128060> What does orpahn mean here? WidgetLayout -> Widget is not a parent child relationship. - Sid Wagle On April 6, 2015, 5:34 p.m., Ivan Kozlov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32803/ > ----------------------------------------------------------- > > (Updated April 6, 2015, 5:34 p.m.) > > > Review request for Ambari, Jaimin Jetly and Sid Wagle. > > > Repository: ambari > > > Description > ------- > > Request for getting order of the widgets specific to a user > /api/v1/users/admin/widget_layouts/default_hdfs_layout > /api/v1/users/admin/widget_layouts?section_name=HDFS_SUMMARY > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java > 7183fa7 > > ambari-server/src/main/java/org/apache/ambari/server/api/resources/WidgetLayoutResourceDefinition.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/api/resources/WidgetResourceDefinition.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/api/services/ClusterService.java > a794693 > > ambari-server/src/main/java/org/apache/ambari/server/api/services/WidgetLayoutService.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/api/services/parsers/JsonRequestBodyParser.java > 5e6df6b > > ambari-server/src/main/java/org/apache/ambari/server/controller/WidgetResponse.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java > 113087c > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/WidgetLayoutResourceProvider.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/controller/spi/Resource.java > 6e5db3a > > ambari-server/src/main/java/org/apache/ambari/server/orm/dao/UserWidgetDAO.java > 834da26 > ambari-server/src/main/java/org/apache/ambari/server/orm/dao/WidgetDAO.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/orm/dao/WidgetLayoutDAO.java > 55e7513 > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/UserWidgetEntity.java > ec84181 > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/WidgetEntity.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/WidgetLayoutEntity.java > dfce4f4 > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/WidgetLayoutUserWidgetEntity.java > 5de9f89 > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog210.java > d1a0bbe > ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 3bfe959 > ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 807306f > ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql f728bdf > ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql > 034639d > ambari-server/src/main/resources/META-INF/persistence.xml 3146aff > ambari-server/src/main/resources/properties.json 300d77e > > ambari-server/src/test/java/org/apache/ambari/server/api/services/parsers/JsonRequestBodyParserTest.java > f89b1b3 > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/WidgetLayoutResourceProviderTest.java > PRE-CREATION > > ambari-server/src/test/java/org/apache/ambari/server/orm/dao/UserWidgetDAOTest.java > f86dde8 > > ambari-server/src/test/java/org/apache/ambari/server/orm/dao/WidgetDAOTest.java > PRE-CREATION > > ambari-server/src/test/java/org/apache/ambari/server/orm/dao/WidgetLayoutDAOTest.java > 3d83399 > > ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog210Test.java > 513e98a > > Diff: https://reviews.apache.org/r/32803/diff/ > > > Testing > ------- > > Tests run: 2819, Failures: 0, Errors: 0, Skipped: 16 > > > Thanks, > > Ivan Kozlov > >
