> On Апрель 6, 2015, 10:38 п.п., Srimanth Gunturi wrote: > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/configuration/hdfs-site.xml, > > line 36 > > <https://reviews.apache.org/r/32784/diff/1/?file=913788#file913788line36> > > > > Is this necessary?
No. Removed in the new patch > On Апрель 6, 2015, 10:38 п.п., Srimanth Gunturi wrote: > > ambari-server/src/main/java/org/apache/ambari/server/agent/DiskInfo.java, > > line 121 > > <https://reviews.apache.org/r/32784/diff/1/?file=913786#file913786line121> > > > > I do not see any usages of this property in this patch. How is it used? I've discovered this small bug while working on this jira and decided to fix. Ambari collects devices info, stores in java instanced field and DB, but doesn't returns it in API response. This information could be used by stack_advisor to calculate recommend values. - Dmytro ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32784/#review79070 ----------------------------------------------------------- On Апрель 2, 2015, 6:20 п.п., Dmytro Sen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32784/ > ----------------------------------------------------------- > > (Updated Апрель 2, 2015, 6:20 п.п.) > > > Review request for Ambari, Myroslav Papirkovskyy and Srimanth Gunturi. > > > Bugs: AMBARI-10332 > https://issues.apache.org/jira/browse/AMBARI-10332 > > > Repository: ambari > > > Description > ------- > > The stack-advisor /recommendations end-point needs to be improved to support > enhanced-configs requirements for HDFS. This includes the support for > property_value_attributes. > > > Diffs > ----- > > ambari-server/src/main/java/org/apache/ambari/server/agent/DiskInfo.java > e3fb88e > > ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/commands/StackAdvisorCommand.java > ce67002 > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/configuration/hdfs-site.xml > 9c704f9 > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py > 2405954 > ambari-server/src/main/resources/stacks/HDP/2.2/services/stack_advisor.py > 87748d2 > ambari-server/src/test/python/stacks/2.2/common/test_stack_advisor.py > d12c067 > > Diff: https://reviews.apache.org/r/32784/diff/ > > > Testing > ------- > > unit tests passed > > > Thanks, > > Dmytro Sen > >
