----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32938/#review79261 -----------------------------------------------------------
Ship it! Ship It! - Mahadev Konar On April 7, 2015, 9:37 p.m., Robert Nettleton wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32938/ > ----------------------------------------------------------- > > (Updated April 7, 2015, 9:37 p.m.) > > > Review request for Ambari, John Speidel, Mahadev Konar, and Sumit Mohanty. > > > Bugs: AMBARI-10388 > https://issues.apache.org/jira/browse/AMBARI-10388 > > > Repository: ambari > > > Description > ------- > > This patch resolves AMBARI-10388. > > The Blueprint configuration processor did not > previously handle the case of a host group > name that included the "-" character. > > Using this "-" character in a host group name > resulted in the Blueprint configuration processor > incorrectly generating invalid configuration > value entries when attempting to substitute host > names for host group names. > > This patch resolves the issue by modifiying the regular > expression pattern used by the BlueprintConfigurationProcessor > to detect host group names in a given configuration property. The > pattern will now accept all non-whitespace characters, rather than > just alphanumeric content, which previously excluded the "-" > character. This should allow for more flexible naming > of host groups in general as well. > > This patch also adds new unit tests to verify that this change > addresses this problem in single host and multiple-host > property values. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java > 04027af > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java > d8794ac > > Diff: https://reviews.apache.org/r/32938/diff/ > > > Testing > ------- > > 1. Ran ambari-server unit tests related to Blueprints. Will be running full > ambari-server unit test suite shortly. > 2. Manually verified that I can start a 3-node HDFS NameNode HA cluster, > using a Blueprint with host groups that include "-" in the host group names, > and verified that the multi-host configuration elements are properly > configured with host names after deployment completes. > > > Thanks, > > Robert Nettleton > >
