----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32957/#review79318 -----------------------------------------------------------
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/widgets.json <https://reviews.apache.org/r/32957/#comment128575> Extra space at the end. ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/widgets.json <https://reviews.apache.org/r/32957/#comment128573> Typo. "Garnage" should be "Garbage" ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/widgets.json <https://reviews.apache.org/r/32957/#comment128574> Why is this repeated? ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/widgets.json <https://reviews.apache.org/r/32957/#comment128576> This should be "DataNode Garbage Collection Time"? ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/widgets.json <https://reviews.apache.org/r/32957/#comment128577> This should be "DataNode Garbage Collection Time"? ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/widgets.json <https://reviews.apache.org/r/32957/#comment128578> This should be "DataNode JVM Heap Memory Used"? ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/widgets.json <https://reviews.apache.org/r/32957/#comment128579> This should be "DataNode JVM Heap Memory Used"? ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/widgets.json <https://reviews.apache.org/r/32957/#comment128580> For this and other NodeManager metrics, shouldn't we just say NodeManager rather than YARN? For example, "NodeManager Garbage Collection Time" rather than "YARN Garbage Collection Time". - Yusaku Sako On April 8, 2015, 2:35 a.m., Jaimin Jetly wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32957/ > ----------------------------------------------------------- > > (Updated April 8, 2015, 2:35 a.m.) > > > Review request for Ambari, Sid Wagle and Yusaku Sako. > > > Bugs: AMBARI-10393 > https://issues.apache.org/jira/browse/AMBARI-10393 > > > Repository: ambari > > > Description > ------- > > This includes updating HBase widgets.json and adding HDFS and YARN > widgets.json files. These are default widget definitions which will be used > to populate widget instances in ambari database on respective service > resource creation (This will done with a seperate ticket). > > > Diffs > ----- > > > ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/metrics.json > 7bbf7be > > ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/widgets.json > a64a2c8 > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/metrics.json > 6fc808e > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/widgets.json > PRE-CREATION > > ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/widgets.json > PRE-CREATION > > Diff: https://reviews.apache.org/r/32957/diff/ > > > Testing > ------- > > Manually Teseted the patch on cluster > > > Thanks, > > Jaimin Jetly > >
