----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32883/#review79371 -----------------------------------------------------------
ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/nimbus.py <https://reviews.apache.org/r/32883/#comment128642> We dont need this check anymore. Change the install code to be same as Linux and refactor. ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/service_mapping.py <https://reviews.apache.org/r/32883/#comment128643> Move service_mapping to status_params. See OOZIE service refactoring for reference. ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/supervisor.py <https://reviews.apache.org/r/32883/#comment128646> Check not required and install() can be refactored. ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/ui_server.py <https://reviews.apache.org/r/32883/#comment128647> Check not required and refactor install() - Jayush Luniya On April 6, 2015, 2:44 p.m., Artem Baranchuk wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32883/ > ----------------------------------------------------------- > > (Updated April 6, 2015, 2:44 p.m.) > > > Review request for Ambari, Eugene Chekanskiy, Florian Barca, and Jayush > Luniya. > > > Bugs: AMBARI-10365 > https://issues.apache.org/jira/browse/AMBARI-10365 > > > Repository: ambari > > > Description > ------- > > [WinTP2] Merge HDPWIN STORM package scripts to common services > > > Diffs > ----- > > > ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/nimbus.py > 6c4fec3 > > ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/params.py > d6e3881 > > ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/params_linux.py > PRE-CREATION > > ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/params_windows.py > PRE-CREATION > > ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/service_check.py > 4eec899 > > ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/service_mapping.py > PRE-CREATION > > ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/storm.py > 3ae3f92 > > ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/supervisor.py > e5852a3 > > ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/ui_server.py > cd0ba0a > > ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/yaml_utils.py > 0034123 > > ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/STORM/configuration/storm-env.xml > 4d9aae6 > > ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/STORM/configuration/storm-site.xml > c0143f1 > > ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/STORM/package/scripts/nimbus.py > 322ecfd > > ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/STORM/package/scripts/params.py > 8495720 > > ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/STORM/package/scripts/service_check.py > 788044a > > ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/STORM/package/scripts/service_mapping.py > 254abd2 > > ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/STORM/package/scripts/status_params.py > bd97604 > > ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/STORM/package/scripts/storm.py > e0bc25b > > ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/STORM/package/scripts/supervisor.py > 079f51f > > ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/STORM/package/scripts/ui_server.py > ebd2830 > > ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/STORM/package/scripts/yaml_config.py > a66f2a3 > > ambari-server/src/main/resources/stacks/HDPWIN/2.2/services/STORM/configuration/storm-site.xml > 1a50e8f > > Diff: https://reviews.apache.org/r/32883/diff/ > > > Testing > ------- > > [INFO] > ------------------------------------------------------------------------ > [INFO] Reactor Summary: > [INFO] > [INFO] Ambari Views ...................................... SUCCESS [4.642s] > [INFO] Ambari Metrics Common ............................. SUCCESS [1.491s] > [INFO] Ambari Server ..................................... SUCCESS [1:16.586s] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Artem Baranchuk > >
