> On April 8, 2015, 4:01 p.m., Jayush Luniya wrote: > > ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/stack_advisor.py, > > line 96 > > <https://reviews.apache.org/r/32894/diff/2/?file=920431#file920431line96> > > > > Remove unused parameters services, hosts
The framework calls these functionw with 5 parameters. The functions never erred because the missing comma below was invalidating the whole script, hence the functions were never executed. - Florian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32894/#review79362 ----------------------------------------------------------- On April 8, 2015, 4:22 a.m., Florian Barca wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32894/ > ----------------------------------------------------------- > > (Updated April 8, 2015, 4:22 a.m.) > > > Review request for Ambari, Artem Baranchuk, Andrew Onischuk, Eugene > Chekanskiy, Jayush Luniya, and Mahadev Konar. > > > Bugs: AMBARI-10368 > https://issues.apache.org/jira/browse/AMBARI-10368 > > > Repository: ambari > > > Description > ------- > > Fixed Hive default parameters for HDP 2.1. > > > Diffs > ----- > > > ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/stack_advisor.py > 3353af1a113280559b27e318bdc62d499cb78630 > > ambari-server/src/main/resources/stacks/HDPWIN/2.2/services/stack_advisor.py > PRE-CREATION > > Diff: https://reviews.apache.org/r/32894/diff/ > > > Testing > ------- > > mvn clean install > > deployment on a local VM cluster -> check for datanucleus.autoCreateSchema > value for HDP 2.1 and HDP 2.2 -> as expected -> ok > > > Thanks, > > Florian Barca > >
