[ 
https://issues.apache.org/jira/browse/AMBARI-9993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14488298#comment-14488298
 ] 

Alejandro Fernandez commented on AMBARI-9993:
---------------------------------------------

[~ndimiduk], thank you for your contribution. Can you upload the patch to 
reviews.apache.org so others can comment?

A couple of comments,
daemon_script = format('/usr/hdp/current/phoenix/bin/queryserver.py') doesn't 
seen format since it's just a string
Are the packages already available on the various OS'es?

Your service will likely also need start/stop/status to be functional. Can you 
confirm these work.
Lastly, we typically also add unit tests for new services, take a look at 
ambari-server/src/test/python/stacks/2.3/MAHOUT/test_mahout_service_check.py as 
an example.


> Add support for management of Phoenix Query Server to HDP Stack
> ---------------------------------------------------------------
>
>                 Key: AMBARI-9993
>                 URL: https://issues.apache.org/jira/browse/AMBARI-9993
>             Project: Ambari
>          Issue Type: Improvement
>          Components: ambari-server
>    Affects Versions: 2.1.0
>            Reporter: Jeff Sposetti
>            Assignee: Nick Dimiduk
>             Fix For: 2.1.0
>
>         Attachments: 9993.patch, 9993.patch
>
>
> Add support to install, manage and monitor the Phoenix Query Server.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to