> On Апрель 6, 2015, 4:23 п.п., Florian Barca wrote: > > ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_decommission.py, > > line 38 > > <https://reviews.apache.org/r/32884/diff/1/?file=916480#file916480line38> > > > > Ths specific code starts here. How about keeping the > > if+hosts=...+for+if host common, and use a specific function to handle the > > task? Something like: > > if params.hbase_drain_only == True: > > decommission_fn = decommission_drain_only > > else: > > decommission_fn = decommission_normal
Think we don't need to complicate the codes by creating of separate methods which will only execute the different commands. I did some refactoring here but only for reduce the line count. Think that is what you meant but without splitting the method. - Artem ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32884/#review78926 ----------------------------------------------------------- On Апрель 8, 2015, 11:22 п.п., Artem Baranchuk wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32884/ > ----------------------------------------------------------- > > (Updated Апрель 8, 2015, 11:22 п.п.) > > > Review request for Ambari, Eugene Chekanskiy, Florian Barca, and Jayush > Luniya. > > > Bugs: AMBARI-10367 > https://issues.apache.org/jira/browse/AMBARI-10367 > > > Repository: ambari > > > Description > ------- > > [WinTP2] Merge HDPWIN HBASE package scripts to common services > > > Diffs > ----- > > > ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase.py > 06e0481 > > ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_client.py > f66ea16 > > ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_decommission.py > a623927 > > ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_master.py > 21bd31d > > ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_regionserver.py > d7c5bf9 > > ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params.py > 98f0473 > > ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py > PRE-CREATION > > ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_windows.py > PRE-CREATION > > ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/service_check.py > eea1cd1 > > ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/status_params.py > c945049 > > ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/HBASE/package/files/draining_servers.rb > a3958a6 > > ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/HBASE/package/scripts/hbase.py > b0a52bb > > ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/HBASE/package/scripts/hbase_client.py > bf2aad0 > > ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/HBASE/package/scripts/hbase_decommission.py > f2a2ad6 > > ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/HBASE/package/scripts/hbase_master.py > d3720d5 > > ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/HBASE/package/scripts/hbase_regionserver.py > e4777a4 > > ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/HBASE/package/scripts/params.py > cd9a74a > > ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/HBASE/package/scripts/service_check.py > c12967b > > ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/HBASE/package/scripts/service_mapping.py > 186b64e > > Diff: https://reviews.apache.org/r/32884/diff/ > > > Testing > ------- > > [INFO] Reactor Summary: > [INFO] > [INFO] Ambari Views ...................................... SUCCESS [4.603s] > [INFO] Ambari Metrics Common ............................. SUCCESS [1.440s] > [INFO] Ambari Server ..................................... SUCCESS [1:18.444s] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Artem Baranchuk > >
