-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33079/
-----------------------------------------------------------
(Updated April 13, 2015, 8:57 p.m.)
Review request for Ambari, Jonathan Hurley, John Speidel, Nate Cole, and Robert
Levas.
Changes
-------
update patch
Bugs: AMBARI-10424
https://issues.apache.org/jira/browse/AMBARI-10424
Repository: ambari
Description
-------
Ability to automatically instantiate a view instance for a cluster during
create based on the stack and services included in the cluster – whether using
blueprints or install wizard (so views are created automatically with a cluster
create). The view itself should describe what stack and services it is
associated with, and when a cluster is created in the ambari the view is deploy
in, a view instance is automatically created. Ambari Admins should have an
option to override this setting in case they do not want the view instances
automatically created. This includes support for designating in the view.xml
stack and services support for a view. Similar to the way min-ambari-version is
specified, the view developer needs a way to identify that the view works with
stack(s) (such as "HDP-2.2" or "HDP-2.2, HDP 2.3" or "HDP-2*") and what
services need to be in the cluster ("YARN" or" YARN, HIVE"). Once a cluster is
created matching those stack + service requirements, the view is automatic
ally instantiated.
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/view/ViewRegistry.java
1ae1dfd
ambari-server/src/main/java/org/apache/ambari/server/view/configuration/AutoInstanceConfig.java
PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/view/configuration/ViewConfig.java
c617b7f
ambari-server/src/test/java/org/apache/ambari/server/api/handlers/CreateHandlerTest.java
87c07c8
ambari-server/src/test/java/org/apache/ambari/server/api/handlers/DeleteHandlerTest.java
7e19129
ambari-server/src/test/java/org/apache/ambari/server/api/handlers/UpdateHandlerTest.java
5ef3e53
ambari-server/src/test/java/org/apache/ambari/server/api/resources/BaseResourceDefinitionTest.java
da3fe3f
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java
baa885c
ambari-server/src/test/java/org/apache/ambari/server/view/ViewRegistryTest.java
3a57b1b
ambari-server/src/test/java/org/apache/ambari/server/view/configuration/AutoInstanceConfigTest.java
PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/view/configuration/ViewConfigTest.java
1875238
ambari-views/src/main/resources/view.xsd b5ed669
Diff: https://reviews.apache.org/r/33079/diff/
Testing
-------
Manual tested that adding service will trigger auto creation and that the new
view instance is associated with that cluster.
New unit tests added.
All tests pass.
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 34:51 min
[INFO] Finished at: 2015-04-09T17:28:29-04:00
[INFO] Final Memory: 52M/603M
[INFO] ------------------------------------------------------------------------
Thanks,
Tom Beerbower
